Add regexp/no-optional-assertion rule
#135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 tasks
RunDevelopment
requested changes
Apr 16, 2021
Collaborator
RunDevelopment
left a comment
RunDevelopment
left a comment
There was a problem hiding this comment.
LGTM apart from the docs... Sorry.
Co-authored-by: Michael Schmidt <[email protected]>
ota-meshi
force-pushed
the
no-optional-assertion
branch
from
a39adba to
5c4ebbd
Compare
Owner
Author
|
Thank you for your review! I made changes to this PR. |
|
|
||
| ### `"allowed": "alphanumeric"` | ||
|
|
||
| <eslint-code-block fix> |
Collaborator
There was a problem hiding this comment.
Ah, my bad. Sorry.
RunDevelopment
approved these changes
Apr 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed to avoid some recursive processing compared to clean-regex/no-optional-assertion.