Skip to content

Conversation

@RunDevelopment
Copy link
Collaborator

This is the clean-regex/no-trivially-nested-lookaround rule but with a different name and this bug fixed.

I renamed it because the "trivially nested assertion" is the inner assertion (e.g. in /(?=(?!a))/, the trivially nested assertion is (?!a)). Since the inner assertion can be any assertion and not just a lookaround, I renamed the rule.

Copy link
Owner

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR! Almost LGTM.

Is it better to change the new script?

Copy link
Owner

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for changing it!

@RunDevelopment
Copy link
Collaborator Author

@ota-meshi Do you have a merge policy? I just merge past PRs as soon as they were approved and mergeable to move quickly. Should I not have done that?

@ota-meshi
Copy link
Owner

I was wondering when to merge 😅.
You and I are the two maintainers of this plugin, so do you think it would be good to merge them as soon as we Approve?
If so, I will merge as soon as I think your PR is good.

@RunDevelopment
Copy link
Collaborator Author

You and I are the two maintainers of this plugin

No, I'm currently only a collaborator. This project isn't in an organization, so there can't be any maintainers from my understanding.

do you think it would be good to merge them as soon as we Approve?

I think it is. No need to keep PRs open if you think they are good to go.

If the author of a PR thought that the PR still needs some changes, then the author should either say that or convert the PR into a draft.


I'll merge this now since you approved :)

@RunDevelopment RunDevelopment merged commit 9f61a3e into master Apr 15, 2021
@RunDevelopment RunDevelopment deleted the no-trivially-nested-assertion branch April 15, 2021 10:51
@ota-meshi
Copy link
Owner

ota-meshi commented Apr 15, 2021

No, I'm currently only a collaborator. This project isn't in an organization, so there can't be any maintainers from my understanding.

I didn't know much about it. Do you think this project should move to an organization for this project?
(I'm not familiar with how to create an GitHub organization yet.)

I'm not sticking to owning this project. If you want to move to your organization, I would like to move to that organization.

@RunDevelopment
Copy link
Collaborator Author

Do you think this project should move to an organization for this project?

AFAIK, the main reasons people make organizations are:

  1. Organization multiple projects.
  2. Organizing teams/people. (This is what makes maintainers.)
  3. Moneatziation/Sponsioring.

We don't have multiple projects or sponsoring right now, so that's not an issue. If more people joined or you wanted to someday stop working on the project, then we can make an organization. Until then, I don't think we need an organization.

The only difference between maintainers and collaborators is that collaborators can't access the settings tab. So it's not really a hindrance, right now.

That being said, I very much appreciate your offer.

@ota-meshi
Copy link
Owner

Thank you for sharing your thoughts.

Until then, I don't think we need an organization.

I understand. If we think we need something, let us talk again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants