-
Notifications
You must be signed in to change notification settings - Fork 14
Added regexp/no-trivially-nested-assertion rule
#120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ota-meshi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR! Almost LGTM.
Is it better to change the new script?
Co-authored-by: Yosuke Ota <[email protected]>
ota-meshi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for changing it!
|
@ota-meshi Do you have a merge policy? I just merge past PRs as soon as they were approved and mergeable to move quickly. Should I not have done that? |
|
I was wondering when to merge 😅. |
No, I'm currently only a collaborator. This project isn't in an organization, so there can't be any maintainers from my understanding.
I think it is. No need to keep PRs open if you think they are good to go. If the author of a PR thought that the PR still needs some changes, then the author should either say that or convert the PR into a draft. I'll merge this now since you approved :) |
I didn't know much about it. Do you think this project should move to an organization for this project? I'm not sticking to owning this project. If you want to move to your organization, I would like to move to that organization. |
AFAIK, the main reasons people make organizations are:
We don't have multiple projects or sponsoring right now, so that's not an issue. If more people joined or you wanted to someday stop working on the project, then we can make an organization. Until then, I don't think we need an organization. The only difference between maintainers and collaborators is that collaborators can't access the settings tab. So it's not really a hindrance, right now. That being said, I very much appreciate your offer. |
|
Thank you for sharing your thoughts.
I understand. If we think we need something, let us talk again. |
This is the
clean-regex/no-trivially-nested-lookaroundrule but with a different name and this bug fixed.I renamed it because the "trivially nested assertion" is the inner assertion (e.g. in
/(?=(?!a))/, the trivially nested assertion is(?!a)). Since the inner assertion can be any assertion and not just a lookaround, I renamed the rule.