Skip to content

Prevent url clipping for GHES instances #1225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 1, 2023
Merged

Prevent url clipping for GHES instances #1225

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db3b971
Update github.go
rajbos Jul 10, 2023
f086d03
Merge branch 'main' into rajbos-patch-1
spencerschrock Aug 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions github/github.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,11 +85,7 @@ func (c *Client) ParseFromURL(baseRepoURL, repoName string) (RepoInfo, error) {
if err != nil {
return ret, fmt.Errorf("parsing base repo URL: %w", err)
}

repoURL, err := baseURL.Parse(fmt.Sprintf("repos/%s", repoName))
if err != nil {
return ret, fmt.Errorf("parsing repo endpoint: %w", err)
}
repoURL := baseURL.JoinPath(fmt.Sprintf("repos/%s", repoName))

log.Printf("getting repo info from URL: %s", repoURL.String())
//nolint:noctx
Expand Down