Add Milestone 2 documentation. #175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Caleb Brown <[email protected]>
Signed-off-by: Caleb Brown <[email protected]>
oliverchang
previously approved these changes
Nov 21, 2022
Contributor
oliverchang
left a comment
oliverchang
left a comment
There was a problem hiding this comment.
thanks! This looks great!
Just some minor comments:
- The SVG has a transparent background which makes the arrows difficult to see in dark mode.
- Can we have more links to the code that was implemented? This would be very helpful for any other contributors to follow along.
Signed-off-by: Caleb Brown <[email protected]>
Signed-off-by: Caleb Brown <[email protected]>
oliverchang
previously approved these changes
Jan 20, 2023
Signed-off-by: Caleb Brown <[email protected]>
oliverchang
approved these changes
Jan 22, 2023
nathannaveen
pushed a commit
to nathannaveen/criticality_score
that referenced
this pull request
Feb 9, 2023
* Add draft Milestone 2 doc so WG members can see it early. * Update m2 docs Signed-off-by: Caleb Brown <[email protected]> * Further updates to the Milestone 2 doc. Signed-off-by: Caleb Brown <[email protected]> * More m2 doc updates. More links. Signed-off-by: Caleb Brown <[email protected]> * typo fix Signed-off-by: Caleb Brown <[email protected]> Signed-off-by: Caleb Brown <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Milestone 2 doc covering the (almost finished) production implementation.