Make containscidr private #3080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nplanelcisco
reviewed
Aug 8, 2025
| @@ -619,6 +620,13 @@ func (t *Table) GetKnownPathListWithMac(id string, as uint32, rt bgp.ExtendedCom | |||
| return paths | |||
| } | |||
|
|
|||
| // ContainsCIDR checks if one IPNet is a subnet of another. | |||
| func containsCIDR(n1, n2 *net.IPNet) bool { | |||
There was a problem hiding this comment.
I feel the whole things (table/ipnet) need to be changed to use netip.Prefix.Contains()
let's merge this one add this to the todolist
There was a problem hiding this comment.
Indeed, we don't need to convert netip.Prefix to net.IPnet. The priority is removing the usage of net.IP* from public APIs. We can clean up the internal usages even after 4.0 release.
nplanelcisco
approved these changes
Aug 8, 2025
Move ContainsCIDR to table package and make it private. Signed-off-by: FUJITA Tomonori <[email protected]>
fujita
force-pushed
the
make-containscidr-private
branch
from
a7f4239 to
23ddee2
Compare
|
@nplanelcisco thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.