pkg/packet/mrt: use netip for BGP4MPHeader and GeoPeer #3078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace net.IP with netip.Addr for BGP4MPHeader, GeoPeer, and GeoPeerTable. Signed-off-by: FUJITA Tomonori <[email protected]>
nplanelcisco
reviewed
Aug 8, 2025
| binary.BigEndian.PutUint32(buf[5:9], math.Float32bits(p.Latitude)) | ||
| binary.BigEndian.PutUint32(buf[9:13], math.Float32bits(p.Longitude)) | ||
| return buf, nil | ||
| } | ||
|
|
||
| func NewGeoPeer(bgpid string, latitude float32, longitude float32) *GeoPeer { | ||
| func NewGeoPeer(bgpid netip.Addr, latitude float32, longitude float32) (*GeoPeer, error) { | ||
| if !bgpid.Is4() { |
There was a problem hiding this comment.
shall we enforce && !bgpid.IsUnspecified() ? (line 703 as well)
There was a problem hiding this comment.
This is a serialization/deserialization library, so I think that it’s better if users can construct whatever binary they want — as long as the values don’t cause GoBGP or the library to crash.
nplanelcisco
reviewed
Aug 8, 2025
| laddr := net.ParseIP(localip).To4() | ||
| if paddr != nil && laddr != nil { | ||
|
|
||
| if !peerip.IsValid() || !localip.IsValid() { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace net.IP with netip.Addr for BGP4MPHeader, GeoPeer, and GeoPeerTable.