apiutil: Add Family argument to NewPath function #3070
Conversation
Add Family argument to NewPath function in order to avoid getting Family from NLRI. The NLRI type and Family do not have a one-to-one correspondence, we can only obtain an incomplete value for Family. Signed-off-by: FUJITA Tomonori <[email protected]>
| @@ -175,7 +175,7 @@ func NewPath(nlri bgp.AddrPrefixInterface, isWithdraw bool, attrs []bgp.PathAttr | |||
| Pattrs: a, | |||
| Age: tspb.New(age), | |||
| IsWithdraw: isWithdraw, | |||
| Family: ToApiFamily(nlri.AFI(), nlri.SAFI()), | |||
There was a problem hiding this comment.
in which case getting the family from the nlri/prefix is not the right way ?
There was a problem hiding this comment.
RF_IPv4_MC and RF_IPv6_MC.
There was a problem hiding this comment.
why not doing it in the prefix itself ? something like
func NewIPAddrPrefix(bits uint8, prefix string) *IPAddrPrefix
p := netip.ParsePrefix("....")
return &IPAddrPrefix{ isMulticast: p.Addr().IsMulticast() , .... }
func (ip4 *IPAddrPrefix) SAFI() {
if ip4.isMulticast {
return RF_IPv4_MC
}
return RF_IPv4_UC
}
There was a problem hiding this comment.
We can. The point to discuss is where to store the relationship between Family and NLRI.
Since the number of AddrPrefixInterfaces increases proportionally to both the number of routes and the number of peers, in a full route environment with 10 peers, if NLRI increases by 4 bytes, memory usage would increase by 40MB. Storing Family information in NLRI does not seem ideal.
Note that Paths in the same Destination should share the NLRI. We need to remove PathID info (that is, PrefixDefault) from NLRI before that.
There was a problem hiding this comment.
I think we can do this way #3081
Add Family argument to NewPath function in order to avoid getting Family from NLRI. The NLRI type and Family do not have a one-to-one correspondence, we can only obtain an incomplete value for Family.