packet/mrt: Add Family argument to NewRib #3069
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Family argument to NewRib function in order to avoid getting Family from NLRI. The NLRI type and Family do not have a one-to-one correspondence, we can only obtain an incomplete value for Family. Signed-off-by: FUJITA Tomonori <[email protected]>
nplanelcisco
reviewed
Aug 5, 2025
| @@ -187,7 +187,7 @@ func TestMrtRib(t *testing.T) { | |||
| e2 := NewRibEntry(2, uint32(time.Now().Unix()), 0, p, false) | |||
| e3 := NewRibEntry(3, uint32(time.Now().Unix()), 0, p, false) | |||
|
|
|||
| r1 := NewRib(1, bgp.NewIPAddrPrefix(24, "192.168.0.0"), []*RibEntry{e1, e2, e3}) | |||
| r1 := NewRib(1, bgp.RF_IPv4_UC, bgp.NewIPAddrPrefix(24, "192.168.0.0"), []*RibEntry{e1, e2, e3}) | |||
There was a problem hiding this comment.
I think rib family should be addressed by prefix parsing as suggested here https://github.com/osrg/gobgp/pull/3070/files#r2251531518
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Family argument to NewRib function in order to avoid getting Family from NLRI. The NLRI type and Family do not have a one-to-one correspondence, we can only obtain an incomplete value for Family.