Skip to content

Input improvements #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 14, 2023
Merged

Input improvements #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
664628e
improve: add `description` and `disabled` props
oskar-gmerek May 14, 2023
0d0ebf9
improve: add `placeholder` prop
oskar-gmerek May 14, 2023
34a6331
improve: support for `email` type input
oskar-gmerek May 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/lib/components/select/Select.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
export let description = '';
export let containerStyle = '';
export let placeholder = '';
export let disabled = false;
type Options =
| {
label: string;
Expand All @@ -25,13 +26,13 @@
<label for={id}>{label}</label>
{/if}
{#if description}
<div class="fg:white/.6">Description of input</div>
<div class="fg:white/.6">{description}</div>
{/if}
<div class={` bg:rgb(8,19,33) flex align-items:center mt:10 mb:30 ` + ' ' + containerStyle}>
<select {id} class={className + ' ' + mcss} {name} bind:value on:change {placeholder}>
{#if options}
{#each options as option}
<option value={option.value}>{option.label}</option>
<option value={option.value} {disabled}>{option.label}</option>
{/each}
{:else}
<slot name="options" />
Expand Down
41 changes: 37 additions & 4 deletions src/lib/components/textInput/TextInput.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,15 @@
<script lang="ts">
import randomString from '$lib/utils/randomString';
import { slide } from 'svelte/transition';
export let value = '';
export let name = '';
export { className as class };
export let label = '';
export let description = '';
export let placeholder = '';
let className =
'w:full h:full p:16 outline:4|solid|rgb(8,19,33) outline:4|solid|orange:focus ~outline|0.5s r:7 ';
export let error = '';
export let type = 'text';
let className = `w:full h:full p:16 outline:4|solid|rgb(8,19,33) outline:4|solid|orange:focus ~outline|0.5s r:7`;

const id = randomString(7);
</script>
Expand All @@ -18,6 +20,37 @@
{#if description}
<div class="fg:white/.6">{description}</div>
{/if}
<div class="bg:rgb(8,19,33) mt:10 mb:30">
<input {id} class={className} type="text" {name} bind:value {placeholder} />
<div class="mb:30">
<div
class={`bg:rgb(8,19,33) mt:10 ${
error ? 'bg:red-20 outline:4|solid|red>input mb:10' : 'mb:30'
}`}
>
{#if type === 'email'}
<input
{id}
class={className}
type="email"
{name}
bind:value
{placeholder}
on:change={() => (error = '')}
/>
{:else}
<input
{id}
class={className}
type="text"
{name}
bind:value
{placeholder}
on:change={() => (error = '')}
/>
{/if}
</div>
{#if error}
<div class="fg:red" transition:slide={{ delay: 50, duration: 150, axis: 'y' }}>
{error}
</div>
{/if}
</div>
2 changes: 2 additions & 0 deletions src/lib/components/textarea/TextArea.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
export let maxlength = 5000;
export let label = '';
export let description = '';
export let placeholder = '';
export { className as class };

const id = randomString(7);
Expand Down Expand Up @@ -39,6 +40,7 @@
bind:this={textarea}
bind:value
on:input={textareaResize}
{placeholder}
/>
{#if value.length > 0}
<div
Expand Down