Make the number of builds per group on the front page configurable #6843
Conversation
AdamWill
force-pushed
the
front-page-builds-configurable
branch
from
1e19008 to
9a2f92e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6843 +/- ##
=======================================
Coverage 99.26% 99.26%
=======================================
Files 402 402
Lines 41396 41402 +6
=======================================
+ Hits 41090 41096 +6
Misses 306 306 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
etc/openqa/openqa.ini
Outdated
| #api_hmac_time_tolerance = 300 | ||
| ## How many builds to show per job group on the web UI front page | ||
| ## Can be overridden with the limit_builds query param | ||
| # frontpage_builds = 3 |
There was a problem hiding this comment.
I think we can the page either index page or dashboard. I wouldn't introduce another term but if we already use frontpage elsewhere then it's fine
There was a problem hiding this comment.
Well, I think it's usually called 'dashboard', but it seems to be mostly in source code, not user/admin-facing docs. The word appears a few times in docs/UsersGuide.asciidoc , but only one time is it specifically referring to the home page and it doesn't really explain what it means (just says "index dashboard"). As a user/admin, if you say "dashboard" or "index dashboard" I really don't know what you mean. If you say "front page", I know what you mean. Still, I guess the comment explains it.
We can't really change it to 'dashboard_builds', though, because the group overviews are also called 'dashboards' and they do not use this value (and default to 10). So it'd have to be index_dashboard_builds ?
There was a problem hiding this comment.
ok, fine. I guess at least "frontpage" is unique and not ambiguous :)
d3flex
left a comment
d3flex
left a comment
There was a problem hiding this comment.
Also I think the [misc_limits] is better fit for this variable. wdyt?
No. misc_limits is for asset limits, storage limits, functional limits but not display preferences. IMHO the current place for the newly added variable is fine |
The number of builds to show per job group on the front page of the web UI is hardcoded to 3. SUSE's openQA has a ton of job groups so only showing three per group makes sense, but not every instance has so many groups, and the front page can look unnecessarily empty. This allows the instance maintainer to set an appropriate value. The value can be overridden for a single query with the limit_builds query param, but that's unwieldy and doesn't solve things for casual views of the home page. Signed-off-by: Adam Williamson <[email protected]>
AdamWill
force-pushed
the
front-page-builds-configurable
branch
from
9a2f92e to
3971eed
Compare
Martchus
left a comment
Martchus
left a comment
There was a problem hiding this comment.
I still find that misc_limits is more intuitive. (And we do have display limits like next_jobs_default_limit there.) However, I don't really care so I'm approving.
5 participants
The number of builds to show per job group on the front page of the web UI is hardcoded to 3.
SUSE's openQA has a ton of job groups so only showing three per group makes sense, but not every instance has so many groups, and the front page can look unnecessarily empty. This allows the instance maintainer to set an appropriate value.
The value can be overridden for a single query with the limit_builds query param, but that's unwieldy and doesn't solve things for casual views of the home page.