-
Notifications
You must be signed in to change notification settings - Fork 220
Skip a build if there are no jobs #6840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I think I can only unit-test this by splitting up |
b2b07aa to
962dcff
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6840 +/- ##
=======================================
Coverage 99.26% 99.26%
=======================================
Files 402 402
Lines 41396 41396
=======================================
Hits 41090 41090
Misses 306 306 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d3flex
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was about to approve but I notice a tiny drop in the coverage. https://app.codecov.io/gh/os-autoinst/openQA/pull/6840/indirect-changes
it makes me think that it might not that simple as it looks like, Why does it effect this part in the cancel(). Could you take a look. Maybe is nothing
I assume that's a flaky coverage and is unrelated. My change has nothing to do with cancelling. |
My theory: due to a race condition there might not be any job left in a build, when we get start to process it, because all were jobs deleted meanwhile. Issue: https://progress.opensuse.org/issues/192496
962dcff to
4b5e144
Compare
i hear you.. gonna approve |
yep, the coverage change is gone now |
|
@d3flex can you create a ticket for covering the line you linked to with the flaky coverage? thx |
My theory: due to a race condition there might not be any job left in a build,
when we start to process it, because all were jobs deleted meanwhile.
Issue: https://progress.opensuse.org/issues/192496