Skip to content

Conversation

@perlpunk
Copy link
Contributor

@perlpunk perlpunk commented Nov 14, 2025

My theory: due to a race condition there might not be any job left in a build,
when we start to process it, because all were jobs deleted meanwhile.

Issue: https://progress.opensuse.org/issues/192496

@perlpunk perlpunk changed the title Compute build results Skip a build if there are no jobs Nov 14, 2025
@perlpunk
Copy link
Contributor Author

I think I can only unit-test this by splitting up compute_build_results.
I will have a look into it.

@perlpunk perlpunk force-pushed the compute-build-results branch from b2b07aa to 962dcff Compare November 14, 2025 18:41
@codecov
Copy link

codecov bot commented Nov 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.26%. Comparing base (52145e9) to head (4b5e144).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6840   +/-   ##
=======================================
  Coverage   99.26%   99.26%           
=======================================
  Files         402      402           
  Lines       41396    41396           
=======================================
  Hits        41090    41090           
  Misses        306      306           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@d3flex d3flex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was about to approve but I notice a tiny drop in the coverage. https://app.codecov.io/gh/os-autoinst/openQA/pull/6840/indirect-changes
it makes me think that it might not that simple as it looks like, Why does it effect this part in the cancel(). Could you take a look. Maybe is nothing

@perlpunk
Copy link
Contributor Author

I was about to approve but I notice a tiny drop in the coverage. https://app.codecov.io/gh/os-autoinst/openQA/pull/6840/indirect-changes it makes me think that it might not that simple as it looks like, Why does it effect this part in the cancel(). Could you take a look. Maybe is nothing

I assume that's a flaky coverage and is unrelated. My change has nothing to do with cancelling.
I can do a force push and see if it changes something.

My theory: due to a race condition there might not be any job left in a build,
when we get start to process it, because all were jobs deleted meanwhile.

Issue: https://progress.opensuse.org/issues/192496
@perlpunk perlpunk force-pushed the compute-build-results branch from 962dcff to 4b5e144 Compare November 14, 2025 20:00
@d3flex
Copy link
Contributor

d3flex commented Nov 14, 2025

I was about to approve but I notice a tiny drop in the coverage. https://app.codecov.io/gh/os-autoinst/openQA/pull/6840/indirect-changes it makes me think that it might not that simple as it looks like, Why does it effect this part in the cancel(). Could you take a look. Maybe is nothing

I assume that's a flaky coverage and is unrelated. My change has nothing to do with cancelling. I can do a force push and see if it changes something.

i hear you.. gonna approve

@perlpunk
Copy link
Contributor Author

I assume that's a flaky coverage and is unrelated. My change has nothing to do with cancelling. I can do a force push and see if it changes something.

yep, the coverage change is gone now

@perlpunk
Copy link
Contributor Author

perlpunk commented Nov 14, 2025

@d3flex can you create a ticket for covering the line you linked to with the flaky coverage? thx

@mergify mergify bot merged commit b36ac75 into os-autoinst:master Nov 14, 2025
51 checks passed
@perlpunk perlpunk deleted the compute-build-results branch November 18, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants