Assure git_clone is only run for valid targets #6805
Conversation
Previously we attempted git_clone including get_origin_url on non-repos or undefined remotes, causing failures before outage handling kicks in. This PR makes it so we verify repos/URLs first. Also i sringified the error object in order to make the regex check more reliable. Related progress issue: https://progress.opensuse.org/issues/190410
| next; | ||
| } | ||
| catch ($e) { $error = $e } | ||
| catch ($e) { $error = "$e" } |
There was a problem hiding this comment.
In perl, if applied to a regex, a variable is automatically stringified, so that should not be necessary
There was a problem hiding this comment.
Have you researched which job was responsible for this minion job failure?
According to the timestamp it must have been https://openqa.suse.de/tests/19332466#settings
which has no distri set.
I think the git_clone task is correct in general, but we should avoid enqueuing jobs if there is no distri.
So probably around here in create_git_clone_list:
https://github.com/os-autoinst/openQA/blob/master/lib/OpenQA/Utils.pm#L544
|
And the according ticket for the "Failed to get origin url (/var/lib/openqa/share/tests): fatal: not a git repository" is actually https://progress.opensuse.org/issues/190686 |
3 participants
Previously we attempted git_clone including get_origin_url on non-repos or undefined remotes, causing failures before outage handling kicks in.
This PR makes it so we verify repos/URLs first.
Also i sringified the error object in order to make the regex check more reliable.
Related progress issue: https://progress.opensuse.org/issues/190410