Skip to content

Conversation

@giuliocalzo
Copy link
Contributor

@giuliocalzo giuliocalzo commented Mar 11, 2025

removing the md5 function for the uuid generation with native pgsql function https://www.postgresql.org/docs/current/uuid-ossp.html

Related issue(s)

#3844

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@giuliocalzo giuliocalzo requested review from a team and aeneasr as code owners March 11, 2025 19:56
@CLAassistant
Copy link

CLAassistant commented Mar 11, 2025

CLA assistant check
All committers have signed the CLA.

@aeneasr
Copy link
Member

aeneasr commented Mar 13, 2025

Hello, could you please sign the CLA? Also please notice that tests are failing, probably due to the changes in this PR

@giuliocalzo giuliocalzo changed the title using gen_random_uuid function using uuid_generate_v4 function Mar 27, 2025
@giuliocalzo giuliocalzo changed the title using uuid_generate_v4 function fix: using uuid_generate_v4 function Mar 27, 2025
@giuliocalzo
Copy link
Contributor Author

hi @aeneasr I've update the PR, all test are now passing (a part Docker Image Scanners but I believe is not related to my change)

@aeneasr
Copy link
Member

aeneasr commented Apr 1, 2025

Thank you! This looks good to me - quick question - is uuid-ossp supported everywhere? According to the docs it's in Supported Versions: Current (17) / 16 / 15 / 14 / 13

@giuliocalzo
Copy link
Contributor Author

hi @aeneasr unfortunately is only supported for newer version 13+
do you plan to keep supporting EOL postgresql versions ?

@aeneasr
Copy link
Member

aeneasr commented Apr 14, 2025

No, I think version 12 does not need to be supported.

@aeneasr aeneasr merged commit c206066 into ory:master Apr 14, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants