Skip to content

Conversation

mandarvaze
Copy link
Contributor

Add missing title to the frontmatter

Description of change

Added title to address the failing CI build due to missing title front matter in the `architecture.md

How has this been tested? (if applicable)

Not tested.

Add missing `title` to the frontmatter
@mandarvaze mandarvaze requested a review from orhun as a code owner October 27, 2024 00:51
Copy link

codecov bot commented Oct 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 3.31%. Comparing base (19bea73) to head (d85ef90).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #94   +/-   ##
=====================================
  Coverage   3.31%   3.31%           
=====================================
  Files         19      19           
  Lines       2419    2419           
=====================================
  Hits          80      80           
  Misses      2339    2339           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Get changes from architecture.md in the root folder of orhun/binsider main branch (Minor formatting changes)
@orhun
Copy link
Owner

orhun commented Oct 28, 2024

Ah, this should be now at the root of the repository. Can you remove that file instead?

@mandarvaze
Copy link
Contributor Author

@orhun Do you want me to remove website/src/content/docs/architecture.md ?

@orhun
Copy link
Owner

orhun commented Oct 28, 2024

yessir

it is moved to the root of the repo
@mandarvaze
Copy link
Contributor Author

Done ✅ @orhun

Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :)

@orhun orhun changed the title Update architecture.md Remove unnecessary architecture.md Oct 28, 2024
@orhun orhun changed the title Remove unnecessary architecture.md docs(website): remove duplicate architecture.md Oct 28, 2024
@orhun orhun merged commit 419feae into orhun:main Oct 28, 2024
28 checks passed
@mandarvaze mandarvaze deleted the patch-1 branch October 28, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants