Skip to content

Conversation

@lizMSFT
Copy link
Contributor

@lizMSFT lizMSFT commented Sep 2, 2022

improve err msg

Resolves: #290
Signed-off-by: Zoey Li [email protected]

…inguish platform not found and manifest not found

Signed-off-by: Zoey Li <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2022

Codecov Report

Merging #292 (e5691d4) into main (295b1c3) will not change coverage.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##             main     #292   +/-   ##
=======================================
  Coverage   71.17%   71.17%           
=======================================
  Files          37       37           
  Lines        3434     3434           
=======================================
  Hits         2444     2444           
  Misses        741      741           
  Partials      249      249           
Impacted Files Coverage Δ
internal/platform/platform.go 81.42% <50.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 880b84b into oras-project:main Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrap errdef.ErrNotFound with richer error message in order to distinguish platform not found and manifest not found

3 participants