FileHistoryCache#get() should not modify history cache #3828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahornace
reviewed
Dec 3, 2021
opengrok-indexer/src/main/java/org/opengrok/indexer/configuration/Configuration.java
Outdated
Show resolved
Hide resolved
vladak
force-pushed
the
file_history_cache-get_vs_reindex
branch
3 times, most recently
from
551356d to
3cab5e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the ability of
FileHistoryCache#get()to modify the history cache as this can lead to cache corruption. I find this approach more robust than trying to add detection. This solves the problem described in #1114 (comment)