chore: fix a bug in SimilarProjectAnalyzer #1152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: behnazh-w <[email protected]>
oracle-contributor-agreement
bot
added
the
OCA Verified
art1f1c3R
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses a bug in the
SimilarProjectAnalyzerwhere exceptions were not properly handled. Additionally, it improves efficiency by ensuring that theSIMILAR_PROJECTSheuristic only runs when most other heuristics have failed.Description of changes
The main changes in this PR are:
Exception handling: The bug where exceptions were not properly handled in the
SimilarProjectAnalyzerhas been fixed. See a this CI error.Efficiency improvement: To address performance concerns, the
SIMILAR_PROJECTSheuristic now only runs when the majority of other heuristics have failed. This is achieved by adding those heuristics to thedepends_onlist.Additionally, a TODO has been added to for this known inefficiency.