Skip to content

Update supported Angular versions to v19-20 #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

myabc
Copy link

@myabc myabc commented Jul 23, 2025

Following on from opf/openproject#19288, opf/openproject#19658, etc., this modernises the version of Angular we test and build against.

This should resolve peerDependency warnings downstream:

├─┬ @openproject/octicons-angular 19.25.0
│ ├── ✕ unmet peer @angular/common@^16.1.0: found 20.1.2
│ ├── ✕ unmet peer @angular/core@^16.1.0: found 20.1.2
│ ├── ✕ unmet peer @angular/forms@^16.1.0: found 20.1.2
│ └── ✕ unmet peer @angular/compiler@^16.1.0: found 20.1.2

Relates to:

Copy link

changeset-bot bot commented Jul 23, 2025

🦋 Changeset detected

Latest commit: 7460c5b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@openproject/octicons Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@myabc
Copy link
Author

myabc commented Jul 23, 2025

@HDinger I've also submitted two of the dependency updates as PRs upstream:

@myabc myabc force-pushed the code-maintenance/angular-20 branch from 4423563 to 4352873 Compare July 30, 2025 12:38
myabc added 11 commits July 30, 2025 14:01
    ng update @angular/core@17 @angular/cli@17
    ng update @angular/core@18 @angular/cli@18
    ng update @angular/core@19 @angular/cli@19

And performs automated upgrade:

- Updates non-standalone Directives, Component and Pipes to
  'standalone:false' and removes 'standalone:true' from those who are
  standalone.
    ng update @angular/core@20 @angular/cli@20
ng-packagr v17 and above no longer add inferred `peerDependencies` to
the generated `dist/package.json`.
        The snapshot file is v2, but only v3 is supported.
@myabc myabc force-pushed the code-maintenance/angular-20 branch from 4352873 to 7460c5b Compare July 30, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant