Initial commit #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 1, 2023
ncdc
force-pushed
the
bootstrap
branch
3 times, most recently
from
2bc9f14 to
02b771e
Compare
Signed-off-by: Andy Goldstein <[email protected]>
m1kola
approved these changes
Aug 2, 2023
Member
m1kola
left a comment
m1kola
left a comment
There was a problem hiding this comment.
Looks good to me. The only thing that bothers me slightly is the hardcoded versions (go, cert-manager) in this repo which will likely go out of sync of other repos.
Member
Author
|
@m1kola once all the PRs merge, this is the only place, at least tilt-related, where these versions are specified. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.