Skip to content

✨ controllers: remove reconcile-time validators, refactor related tests #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joelanford merged 1 commit into from
Feb 21, 2024
Merged

✨ controllers: remove reconcile-time validators, refactor related tests #642

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion api/v1alpha1/extension_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,8 @@ type ExtensionSourcePackage struct {
// ExtensionSource defines the source for this Extension, right now, only a package is supported.
type ExtensionSource struct {
// A source package defined by a name, version and/or channel
Package *ExtensionSourcePackage `json:"package,omitempty"`
//+kubebuilder:validation:Required
Package *ExtensionSourcePackage `json:"package"`
}

// ExtensionSpec defines the desired state of Extension
Expand Down
2 changes: 2 additions & 0 deletions config/crd/bases/olm.operatorframework.io_extensions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,8 @@ spec:
required:
- name
type: object
required:
- package
type: object
required:
- serviceAccountName
Expand Down
223 changes: 0 additions & 223 deletions internal/controllers/admission_test.go
View file
Open in desktop

This file was deleted.

Loading