-
Notifications
You must be signed in to change notification settings - Fork 68
🐛 incomplete function chain and renamed function in list-compatibl… #1546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 incomplete function chain and renamed function in list-compatibl… #1546
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
camilamacedo86
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
New changes are detected. LGTM label has been removed. |
…e-bundles hack script
bf65b09 to
d5b142a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1546 +/- ##
=======================================
Coverage 74.25% 74.25%
=======================================
Files 42 42
Lines 3329 3329
=======================================
Hits 2472 2472
Misses 676 676
Partials 181 181
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…e-bundles hack script (operator-framework#1546) Co-authored-by: Artur Zych <[email protected]>
…e-bundles hack script (operator-framework#1546) Co-authored-by: Artur Zych <[email protected]>
Small fix to the hack/tools/catalogs/list-compatible-bundles script that adds the missing
extract-olm-package-propertyfunction to the call chain and uses the correct name of regex filtering function (filter-by-regex-if-necessary), making sure the script works.The main issues here were two:
1.
regex_itdid not exist and was renamed during review of the original PR tofilter-by-regex-if-necessary2.
extract-olm-package-propertycall was missing from the chain meaning the filter function couldn't recognize the structure it was expectingBefore change result:
After change result:
Separated from #1539 as per #1539 (comment)
Reviewer Checklist