Skip to content

Conversation

@awgreene
Copy link
Member

@awgreene awgreene commented Apr 3, 2023

No description provided.

Signed-off-by: Alexander Greene <[email protected]>
same "printed page" as the copyright notice for easier
identification within third-party archives.

Copyright [yyyy] [name of copyright owner]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to specify the copyright information?

Suggested change
Copyright [yyyy] [name of copyright owner]
Copyright 2023 Operator Framework

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, I realize now that is part of the section you apply to the top of each file :)

Is there going to be a separate PR to add the copyright information to all the files?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 we should probably put the copyright info in source code headers.

And we should also probably have a sanity test that checks for the license headers. That could probably be a follow-up though.

Copy link
Contributor

@tmshort tmshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be identical to the Apache license provided by GitHub when you add a license as your initial commit to a repository.

I also compared it to the apache online version at https://www.apache.org/licenses/LICENSE-2.0.txt, and with the exception of a single blank line at the beginning, they are identical.

I will note that OpenSSL is Apache 2.0 licensed, but their license differs:

  1. The URL at the top is http vs https
  2. They don't have the APPENDIX

@awgreene awgreene merged commit a85307e into operator-framework:main Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants