Skip to content

Conversation

@yashoza19
Copy link
Contributor

Description

Fixes #1293

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@yashoza19 yashoza19 requested a review from a team as a code owner September 26, 2024 16:22
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 26, 2024
@netlify
Copy link

netlify bot commented Sep 26, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit ea816a4
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/66f598c8089fac0008e36f2d
😎 Deploy Preview https://deploy-preview-1312--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 26, 2024
Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2024
@LalatenduMohanty
Copy link
Member

@yashoza19 The PR is still work in progress. Can you please remove it ?

Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @yashoza19 !

@everettraven everettraven changed the title ✨ [WIP] Remove the Resolved status condition ✨ Remove the Resolved status condition Sep 26, 2024
@everettraven everettraven added this pull request to the merge queue Sep 26, 2024
Merged via the queue into operator-framework:main with commit 8699d25 Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[v1 API Review] Remove the Resolved status condition

4 participants