-
Notifications
You must be signed in to change notification settings - Fork 68
📖 [Docs] Single ClusterExtension ownership concept #1258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 [Docs] Single ClusterExtension ownership concept #1258
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1258 +/- ##
==========================================
- Coverage 76.18% 76.09% -0.09%
==========================================
Files 40 40
Lines 2330 2330
==========================================
- Hits 1775 1773 -2
- Misses 398 399 +1
- Partials 157 158 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
perdasilva
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - just a couple of small suggestions for your consideration. Great job! Thank you =DD
Signed-off-by: Brett Tofel <[email protected]>
Signed-off-by: Brett Tofel <[email protected]>
Co-authored-by: Per Goncalves da Silva <[email protected]>
Signed-off-by: Brett Tofel <[email protected]>
Signed-off-by: Brett Tofel <[email protected]>
959e820 to
4c839a9
Compare
Signed-off-by: Brett Tofel <[email protected]>
LalatenduMohanty
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
everettraven
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I won't hold this PR on my comment because it is fairly clear throughout the rest of the document that it isn't tied to only custom resources
Co-authored-by: Bryce Palmer <[email protected]>
cb4a7d9
|
New changes are detected. LGTM label has been removed. |
Description
Reviewer Checklist