Skip to content

Conversation

@bentito
Copy link
Contributor

@bentito bentito commented Sep 6, 2024

Documents the new features for catalog selection.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@bentito bentito requested a review from a team as a code owner September 6, 2024 15:10
@netlify
Copy link

netlify bot commented Sep 6, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit e6864f8
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/66db47e1dc412d00085a351c
😎 Deploy Preview https://deploy-preview-1227--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bentito bentito added the kind/documentation Categorizes issue or PR as related to documentation. label Sep 6, 2024
@bentito
Copy link
Contributor Author

bentito commented Sep 6, 2024

Addresses #1154

@codecov
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.53%. Comparing base (de0a41e) to head (e6864f8).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1227   +/-   ##
=======================================
  Coverage   76.53%   76.53%           
=======================================
  Files          40       40           
  Lines        2340     2340           
=======================================
  Hits         1791     1791           
  Misses        392      392           
  Partials      157      157           
Flag Coverage Δ
e2e 57.64% <ø> (ø)
unit 52.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bentito
Copy link
Contributor Author

bentito commented Sep 6, 2024

/assign @dhoover103

@dhoover103
Copy link

Honestly, I don't have anything to add - this already has various examples that I was still working on putting together for my version of the doc.

Signed-off-by: Brett Tofel <[email protected]>
This commit adds a reference to the Kubernetes documentation on working with labels and selectors. It provides more context and resources for understanding catalog selection mechanisms.

Signed-off-by: Brett Tofel <[email protected]>
@joelanford joelanford added this pull request to the merge queue Sep 7, 2024
Merged via the queue into operator-framework:main with commit 65a60bf Sep 7, 2024
@skattoju skattoju mentioned this pull request Sep 25, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/documentation Categorizes issue or PR as related to documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants