Skip to content

⚠️ types conversions from review #1223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
everettraven merged 2 commits into from
Sep 9, 2024
Merged

⚠️ types conversions from review #1223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ab1618
convert to non-pointer types in spec
grokspawn Sep 5, 2024
86d2e02
review resolutions
grokspawn Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion api/v1alpha1/clusterextension_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,7 +377,8 @@ type ServiceAccountReference struct {
Name string `json:"name"`
}

// PreflightConfig holds the configuration for the preflight checks.
// PreflightConfig holds the configuration for the preflight checks. If used, at least one preflight check must be non-nil.
// +kubebuilder:validation:XValidation:rule="has(self.crdUpgradeSafety)",message="at least one of [crdUpgradeSafety] are required when preflight is specified"
type PreflightConfig struct {
// crdUpgradeSafety is used to configure the CRD Upgrade Safety pre-flight
// checks that run prior to upgrades of installed content.
Expand Down
4 changes: 4 additions & 0 deletions config/base/crd/bases/olm.operatorframework.io_clusterextensions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,10 @@ spec:
required:
- crdUpgradeSafety
type: object
x-kubernetes-validations:
- message: at least one of [crdUpgradeSafety] are required when
preflight is specified
rule: has(self.crdUpgradeSafety)
serviceAccount:
description: |-
serviceAccount is a required reference to a ServiceAccount that exists
Expand Down
2 changes: 1 addition & 1 deletion docs/refs/api/operator-controller-api-reference.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ _Appears in:_



PreflightConfig holds the configuration for the preflight checks.
PreflightConfig holds the configuration for the preflight checks. If used, at least one preflight check must be non-nil.



Expand Down