📖 [Docs] Add support for skip ranges and replacements #1215
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
michaelryanpeter
force-pushed
the
issue-744-document-support-for-skip-ranges-and-replacements
branch
from
498792d to
ae1bcea
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1215 +/- ##
=======================================
Coverage 77.56% 77.56%
=======================================
Files 36 36
Lines 1979 1979
=======================================
Hits 1535 1535
Misses 309 309
Partials 135 135
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| installNamespace: <namespace> | ||
| packageName: <package_name> | ||
| serviceAccount: | ||
| name: <service_account> | ||
| upgradeConstraintPolicy: Ignore | ||
| version: "<version_or_version_range>" |
There was a problem hiding this comment.
Non-blocking (I think we'll need to sweep the entire repo once all the API changes are finished): All these fields are getting moved around:
- This example is not currently valid.
- Even if you made it valid according to what is in
mainright now, there are other open PRs that will invalidate it (e.g. ✨ logically group fields in the spec #1200)
There was a problem hiding this comment.
With Material MK Docs, we can actually embed YAML files into a markdown file.
Maybe we can create an issue right before or after 1.0.0 GA to switch our inline examples to embedded YAML files? That way we can update our examples all in one go.
There was a problem hiding this comment.
It looks like #1200 has the relevant doc changes already queued up.
There was a problem hiding this comment.
#1200 merged, which makes this section incorrect if it merges. I'm happy to merge this and fix in a follow up (hence my approval on the PR), but I'll defer to you if you want to go ahead and fix now.
| `Ignore` | ||
| : Does not limit the next version to the set of successors, and instead allows for any downgrade, sidegrade, or upgrade. | ||
|
|
||
| `Enforce` |
There was a problem hiding this comment.
@joelanford Do you want to change to the new value now? Or should we to update #1151 with a comment or a docs issue?
There was a problem hiding this comment.
Use what you have, which is what is on main. The PR for that change should hopefully find/replace these.
3 participants
Closes #744
@perdasilva: I am not sure if you are using this file as part of your work. I just wanted to make sure we aren't stepping on each other's toes :)
Description
Reviewer Checklist