Skip to content

Conversation

@m1kola
Copy link
Member

@m1kola m1kola commented Sep 3, 2024

Description

Small change to update doc comment to reflect the current reality

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Signed-off-by: Mikalai Radchuk <[email protected]>
@m1kola m1kola requested a review from a team as a code owner September 3, 2024 14:26
@netlify
Copy link

netlify bot commented Sep 3, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 1c1bdf1
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/66d71c7ca20da00008caedfe
😎 Deploy Preview https://deploy-preview-1208--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.55%. Comparing base (f4ea259) to head (1c1bdf1).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1208   +/-   ##
=======================================
  Coverage   77.55%   77.55%           
=======================================
  Files          36       36           
  Lines        1978     1978           
=======================================
  Hits         1534     1534           
  Misses        309      309           
  Partials      135      135           
Flag Coverage Δ
e2e 57.63% <ø> (ø)
unit 55.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tmshort tmshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2024
@tmshort tmshort added this pull request to the merge queue Sep 3, 2024
Merged via the queue into operator-framework:main with commit 9e86cfe Sep 3, 2024
@m1kola m1kola deleted the fix_doc_comment branch September 4, 2024 07:02
@skattoju skattoju mentioned this pull request Sep 25, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants