Skip to content

Conversation

@m1kola
Copy link
Member

@m1kola m1kola commented Sep 2, 2024

Description

This resource no longer exists in OLMv1

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

This resource no longer exists in OLMv1

Signed-off-by: Mikalai Radchuk <[email protected]>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 2, 2024
@netlify
Copy link

netlify bot commented Sep 2, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit c653a71
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/66d5de62e1a29f000845e370
😎 Deploy Preview https://deploy-preview-1204--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@m1kola m1kola marked this pull request as ready for review September 2, 2024 15:56
@m1kola m1kola requested a review from a team as a code owner September 2, 2024 15:56
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 2, 2024
@codecov
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.56%. Comparing base (f40d9ca) to head (c653a71).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1204   +/-   ##
=======================================
  Coverage   77.56%   77.56%           
=======================================
  Files          36       36           
  Lines        1979     1979           
=======================================
  Hits         1535     1535           
  Misses        309      309           
  Partials      135      135           
Flag Coverage Δ
e2e 57.65% <ø> (ø)
unit 55.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@everettraven everettraven added this pull request to the merge queue Sep 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 3, 2024
@m1kola m1kola added this pull request to the merge queue Sep 3, 2024
@m1kola
Copy link
Member Author

m1kola commented Sep 3, 2024

Looks like e2e failure is a flake. Retrying.

Merged via the queue into operator-framework:main with commit 39c893c Sep 3, 2024
@m1kola m1kola deleted the cleanup_rbac branch September 3, 2024 14:27
@skattoju skattoju mentioned this pull request Sep 25, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants