Skip to content

Conversation

@tmshort
Copy link
Contributor

@tmshort tmshort commented Aug 30, 2024

Both catalogs should have a package available for the label selector to really demonstrate that it picks one of two catalogs

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Both catalogs should have a package available for the label
selector to really demonstrate that it picks one of two
catalogs

Signed-off-by: Todd Short <[email protected]>
@tmshort tmshort requested a review from a team as a code owner August 30, 2024 16:03
@netlify
Copy link

netlify bot commented Aug 30, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit dd5cf7a
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/66d1ed454dbf870008e3cc44
😎 Deploy Preview https://deploy-preview-1199--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.56%. Comparing base (04ee036) to head (dd5cf7a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1199      +/-   ##
==========================================
+ Coverage   77.27%   77.56%   +0.28%     
==========================================
  Files          35       36       +1     
  Lines        1945     1979      +34     
==========================================
+ Hits         1503     1535      +32     
- Misses        308      309       +1     
- Partials      134      135       +1     
Flag Coverage Δ
e2e 57.65% <ø> (-1.06%) ⬇️
unit 55.53% <ø> (+0.67%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@everettraven everettraven added this pull request to the merge queue Aug 30, 2024
Merged via the queue into operator-framework:main with commit a740410 Aug 30, 2024
@tmshort tmshort deleted the update-test branch August 30, 2024 19:40
@skattoju skattoju mentioned this pull request Sep 25, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants