Skip to content

Conversation

@tmshort
Copy link
Contributor

@tmshort tmshort commented Aug 29, 2024

I have been bitten by this too many times (i.e. running bingo commands in the .bingo directory). I wanted to make sure no one else falls into the same confusion.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

I have been bitten by this too many times (i.e. running `bingo`
commands in the .bingo directory). I wanted to make sure no one
else falls into the same confusion.

Signed-off-by: Todd Short <[email protected]>
@tmshort tmshort requested a review from a team as a code owner August 29, 2024 14:38
@netlify
Copy link

netlify bot commented Aug 29, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 610f3cc
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/66d087ecdbefef000837f7b1
😎 Deploy Preview https://deploy-preview-1186--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.55%. Comparing base (3a9868e) to head (610f3cc).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1186   +/-   ##
=======================================
  Coverage   77.55%   77.55%           
=======================================
  Files          35       35           
  Lines        1916     1916           
=======================================
  Hits         1486     1486           
  Misses        296      296           
  Partials      134      134           
Flag Coverage Δ
e2e 58.76% <ø> (ø)
unit 55.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@perdasilva perdasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2024
@tmshort tmshort added this pull request to the merge queue Aug 29, 2024
Merged via the queue into operator-framework:main with commit 1d64a4d Aug 29, 2024
tmshort added a commit to tmshort/operator-controller that referenced this pull request Sep 3, 2024
Bingo will overwrite this, which can cause issues.

This reverts commit 1d64a4d.
github-merge-queue bot pushed a commit that referenced this pull request Sep 3, 2024
Bingo will overwrite this, which can cause issues.

This reverts commit 1d64a4d.
@skattoju skattoju mentioned this pull request Sep 25, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants