✨ feat: dump csv annotations into chart metadata #1095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1095 +/- ##
==========================================
+ Coverage 75.28% 77.58% +2.29%
==========================================
Files 35 36 +1
Lines 1914 1981 +67
==========================================
+ Hits 1441 1537 +96
+ Misses 330 309 -21
+ Partials 143 135 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gallettilance
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
gallettilance
changed the title
everettraven
previously approved these changes
Aug 6, 2024
everettraven
reviewed
Aug 6, 2024
| } | ||
|
|
||
| chrt := &chart.Chart{Metadata: &chart.Metadata{}} | ||
| chrt.Metadata.Annotations = reg.CSV.GetAnnotations() |
Contributor
There was a problem hiding this comment.
I've already approved, but didn't think about this until after - are there any tests that can/should be updated to verify that this is working as expected?
Member
There was a problem hiding this comment.
Yeah, we should:
- Make sure our test CSV has some annotations
- Make sure (via test assertions) that those annotations make it into chart metadata annotations.
gallettilance
force-pushed
the
dump-annotations
branch
from
80692b6 to
d7858c3
Compare
everettraven
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is needed for the cluster olm operator to find the ocp max version
Reviewer Checklist