Skip to content

Conversation

@dtfranz
Copy link
Contributor

@dtfranz dtfranz commented Jul 17, 2024

Fixes: #998
Cleans up some of the baggage that came with the BundleDeployment API from rukpak.

Changes:

  • Rename BundleDeployment -> BundleSource
  • Remove unneeded DeepCopy generated funcs
  • Remove more unused fields and consts
  • Move BundleSource type into Unpacker pkg

@dtfranz dtfranz requested a review from a team as a code owner July 17, 2024 21:13
@netlify
Copy link

netlify bot commented Jul 17, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 0a8cf9e
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/66984bf2f1487100088aab4e
😎 Deploy Preview https://deploy-preview-1061--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 72.85%. Comparing base (6cd022e) to head (0a8cf9e).
Report is 6 commits behind head on main.

Files Patch % Lines
internal/rukpak/source/unpacker.go 0.00% 9 Missing ⚠️
internal/rukpak/source/image_registry.go 60.00% 2 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1061      +/-   ##
==========================================
+ Coverage   72.50%   72.85%   +0.34%     
==========================================
  Files          32       31       -1     
  Lines        1884     1864      -20     
==========================================
- Hits         1366     1358       -8     
+ Misses        383      371      -12     
  Partials      135      135              
Flag Coverage Δ
e2e 55.51% <50.00%> (+0.17%) ⬆️
unit 45.01% <20.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: dtfranz <[email protected]>
Copy link
Contributor

@tmshort tmshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2024
@tmshort tmshort added this pull request to the merge queue Jul 18, 2024
Merged via the queue into operator-framework:main with commit cae1cf1 Jul 18, 2024
perdasilva pushed a commit to LalatenduMohanty/operator-controller that referenced this pull request Aug 13, 2024
perdasilva pushed a commit to kevinrizza/operator-controller that referenced this pull request Aug 13, 2024
@skattoju skattoju mentioned this pull request Sep 25, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove use of BundleDeployment API

2 participants