-
Notifications
You must be signed in to change notification settings - Fork 69
🌱 BundleDeployment Cleanup #1061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1061 +/- ##
==========================================
+ Coverage 72.50% 72.85% +0.34%
==========================================
Files 32 31 -1
Lines 1884 1864 -20
==========================================
- Hits 1366 1358 -8
+ Misses 383 371 -12
Partials 135 135
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: dtfranz <[email protected]>
tmshort
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Signed-off-by: dtfranz <[email protected]>
Signed-off-by: dtfranz <[email protected]>
Fixes: #998
Cleans up some of the baggage that came with the
BundleDeploymentAPI from rukpak.Changes:
BundleDeployment->BundleSourceDeepCopygenerated funcsconstsBundleSourcetype intoUnpackerpkg