⚠ Remove TLSVerify/PullSecret fields

[thetechnick]

Remove fields that will not have long term support committed to them to prepare for the v1.0 release.

Removed Fields:

• spec.source.image.insecureSkipTLSVerify
• spec.source.image.pullSecret

GH Issue Ref: #355

Draft due to pending e2e test changes.

[joelanford]

I am working on switching operator-controller to containers/image library here: operator-framework/operator-controller#1194

We are also planning to port similar logic to catalogd (and we separately need to decide if we want to somehow centralize/generalize the image unpacking library bits)

I bring this up because there will be a way to inject pull secrets and insecure registry configurations to resolve the e2e issues (e.g. by mounting a configmap that contains the analogous configuration files for insecure registries and credentials)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.48%. Comparing base (dfe121e) to head (c6303d6).
Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #369      +/-   ##
==========================================
+ Coverage   34.41%   34.48%   +0.07%     
==========================================
  Files          17       17              
  Lines         738      722      -16     
==========================================
- Hits          254      249       -5     
+ Misses        452      443       -9     
+ Partials       32       30       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[everettraven]

I am working on switching operator-controller to containers/image library here: operator-framework/operator-controller#1194

We are also planning to port similar logic to catalogd (and we separately need to decide if we want to somehow centralize/generalize the image unpacking library bits)

I bring this up because there will be a way to inject pull secrets and insecure registry configurations to resolve the e2e issues (e.g. by mounting a configmap that contains the analogous configuration files for insecure registries and credentials)

@joelanford There was also changes to the way the e2es are configured in operator-controller recently that we might be able to update catalogd to follow. IIRC the changes in operator-controller made it so that we didn't need to skip TLS verification (since there is no way to set that in the ClusterExtension API)

[thetechnick]

Trying to just get the TLS/Cert changes from operator-controller in, before continuing here:
#377

[thetechnick]

PR to trust certs from image-registry: (Needs to be merged before and this rebased on top)
#377

[perdasilva]

@thetechnick I've taken the liberty of rebasing your PR (please double check that my conflict resolution was what you had in mind =D)

[perdasilva]

/lgtm