Skip to content
This repository was archived by the owner on Mar 3, 2025. It is now read-only.

Conversation

@joelanford
Copy link
Member

@joelanford joelanford commented May 10, 2024

Closes #261

@joelanford joelanford requested a review from a team as a code owner May 10, 2024 13:54
@codecov
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.84%. Comparing base (cf384e4) to head (2dc0d96).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #267   +/-   ##
=======================================
  Coverage   48.84%   48.84%           
=======================================
  Files           8        8           
  Lines         434      434           
=======================================
  Hits          212      212           
  Misses        201      201           
  Partials       21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joelanford joelanford force-pushed the improve-makefile branch 8 times, most recently from c35eba9 to c552a7f Compare May 14, 2024 21:00
Copy link
Member

@varshaprasad96 varshaprasad96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2024
@varshaprasad96 varshaprasad96 added this pull request to the merge queue May 14, 2024
Merged via the queue into operator-framework:main with commit b68cda4 May 14, 2024
@joelanford joelanford deleted the improve-makefile branch May 15, 2024 13:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve Makefile to avoid unnecessarily shelling out multiple times for the same variables

3 participants