-
Notifications
You must be signed in to change notification settings - Fork 13
Chore/refactoring images issue 48 v3 #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/refactoring images issue 48 v3 #53
Conversation
|
@sgort i know about the issue with BPMN diagram rendering. Thx |
83f5641 to
0bc7958
Compare
|
Concering BPMN files: BPMN files are documentation content, not static assets. They should stay with the markdown files. Reasoning:
In the script we now search for: |
|
Manually checking 22 orphaned assets in the dry run, I came across a false positive. "Orphaned" asset Decided to exclude
|
f64c356 to
bd3db85
Compare
|
Before and after analysis: These 5 are among the PNG files in |
ChangesMigration Process
Path Changes
Fixed Issues
Testing✅ Verification Steps Completed
📸 Test Pages
Migration ToolkitAdded comprehensive toolkit in
Checklist
|
🧰 Migration Toolkit (Review Only - Remove Before Merge)Please do not merge the toolkit directory! The |
a-m-zill
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx @sgort for your work.
I have checked a bunch of files and thinks it looks good to me. I have started it local on my computer and can not find broken images. When i miss something, so we can fix it later.
You can now remove the toolkit folder and then we can merge it.
Migration Results: - Successfully migrated 524 assets from docs/ to static/img/ - Updated 102 markdown files with new absolute paths - Organized by documentation section (documentation/, get-started/) - Cleaned up empty img/ directories automatically Assets Migrated: - 438 PNG images - 86 SVG images - Total: 524 files Exclusions (kept in docs/): - 66 BPMN files (used by BPMN diagram viewer) - 2 DMN files (process definitions) - 1 JS file (documentation script - map.js) - Markdown and MDX files Orphaned Assets: - 22 unreferenced files manually reviewed - Moved to toolkit/orphaned-backup/ for safekeeping - Can be reviewed/deleted later Known Issues (to be fixed in next commit): - 16 broken asset references detected - 12 SVG event symbols in BPMN reference - 1 variables PNG - 2 plugin overlay PNGs - 1 start-form PNG - These files were missing before migration - Will be fixed in follow-up commit Migration Configuration: - Excluded extensions: .bpmn, .dmn, .cmmn, .js - Dry-run verified before live execution - Used migrate-assets-enhanced-UPDATED.js
Fixed paths for assets that were flattened during migration: - 12 SVG event symbols in BPMN reference (removed symbols/events/ subdirs) - 1 variables-3.png - 2 plugin overlay PNGs (plugin-points → extend directory) - 1 start-form-generic.png All references now point to correct locations in static/img/ Testing: - All 541 asset references verified working - 0 broken references - BPMN diagrams rendering correctly - All pages load with images displaying properly - Build successful
bd3db85 to
b588e79
Compare
Closes #48
Replaces #51 and #52
Apologies if it seems a bit messy.
BPMN diagram viewer
I'm in the middle of testing my migration efforts and came accross this issue.
The special tag
<div data-bpmn-diagram="../bpmn/catchandthrowpattern"></div>indocs\documentation\reference\bpmn20\events\error-events.mdis meant to render it as an interactive BPMN diagram in the browser.Operaton docs
For Operaton docs state to date, that is not the case though. See screenshot from live.
Camunda docs
On still existing Camunda docs it is working...
Known issue
Is this a known issue? Will I give it a try to get this fixed while testing my migration efforts?