Skip to content

Conversation

@kelson42
Copy link
Contributor

@kelson42 kelson42 commented Nov 3, 2025

Move to "latest" macOS 15 to match the dependences built by kiwix-build. Adding support of aarch64 testing in the CI

@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 26.34%. Comparing base (1c78d67) to head (fe5653a).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #483   +/-   ##
=======================================
  Coverage   26.34%   26.34%           
=======================================
  Files          26       26           
  Lines        2460     2460           
  Branches     1381     1381           
=======================================
  Hits          648      648           
  Misses       1300     1300           
  Partials      512      512           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kelson42 kelson42 marked this pull request as draft November 4, 2025 05:35
@kelson42 kelson42 force-pushed the kelson42-patch-1 branch 2 times, most recently from 6ea164b to 292341f Compare November 4, 2025 19:02
@kelson42 kelson42 marked this pull request as ready for review November 4, 2025 19:02
@kelson42 kelson42 requested a review from Copilot November 4, 2025 19:02
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the GitHub Actions CI workflow to improve security, expand platform coverage, and modernize dependencies. The changes include pinning action versions to commit SHAs, upgrading Python versions, adding security hardening, and extending macOS builds to support both ARM64 and x86_64 architectures.

  • Pins all GitHub Actions to specific commit SHAs for improved security
  • Upgrades Python from 3.12 to 3.13 on macOS and removes version pin for meson
  • Adds matrix build support for both macOS ARM64 and x86_64 architectures

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

export CPPFLAGS="-I$HOME/BUILD_x86_64-apple-darwin/INSTALL/include"
meson . build
MESON_CROSSFILE="$HOME/BUILD_${{matrix.arch_name}}/meson_cross_file.txt"
if [ -e $MESON_CROSSFILE ]; then
Copy link

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable $MESON_CROSSFILE should be quoted to handle potential spaces in paths. Without quotes, the test will fail if the path contains spaces. Change to if [ -e "$MESON_CROSSFILE" ]; then.

Suggested change
if [ -e $MESON_CROSSFILE ]; then
if [ -e "$MESON_CROSSFILE" ]; then

Copilot uses AI. Check for mistakes.
meson . build
MESON_CROSSFILE="$HOME/BUILD_${{matrix.arch_name}}/meson_cross_file.txt"
if [ -e $MESON_CROSSFILE ]; then
MESON_OPTION="$MESON_OPTION --cross-file $MESON_CROSSFILE -Dstatic-linkage=true"
Copy link

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable $MESON_CROSSFILE should be quoted to prevent word splitting. Without quotes, paths with spaces will cause the command to fail. Change to MESON_OPTION=\"$MESON_OPTION --cross-file $MESON_CROSSFILE -Dstatic-linkage=true\".

Suggested change
MESON_OPTION="$MESON_OPTION --cross-file $MESON_CROSSFILE -Dstatic-linkage=true"
MESON_OPTION="$MESON_OPTION --cross-file \"$MESON_CROSSFILE\" -Dstatic-linkage=true"

Copilot uses AI. Check for mistakes.
MESON_CROSSFILE="$HOME/BUILD_${{matrix.arch_name}}/meson_cross_file.txt"
if [ -e $MESON_CROSSFILE ]; then
MESON_OPTION="$MESON_OPTION --cross-file $MESON_CROSSFILE -Dstatic-linkage=true"
cat $MESON_CROSSFILE
Copy link

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable $MESON_CROSSFILE should be quoted to handle potential spaces in paths. Without quotes, the cat command will fail if the path contains spaces. Change to cat \"$MESON_CROSSFILE\".

Suggested change
cat $MESON_CROSSFILE
cat "$MESON_CROSSFILE"

Copilot uses AI. Check for mistakes.
@kelson42 kelson42 force-pushed the kelson42-patch-1 branch 6 times, most recently from 011062a to 0c5913f Compare November 4, 2025 19:28
@kelson42 kelson42 requested a review from Copilot November 5, 2025 03:32
@kelson42 kelson42 merged commit 1484814 into main Nov 5, 2025
12 checks passed
@kelson42 kelson42 deleted the kelson42-patch-1 branch November 5, 2025 03:32
@kelson42 kelson42 added this to the 3.7.0 milestone Nov 5, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants