-
-
Notifications
You must be signed in to change notification settings - Fork 43
Update CI workflow to use macOS 15 #483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #483 +/- ##
=======================================
Coverage 26.34% 26.34%
=======================================
Files 26 26
Lines 2460 2460
Branches 1381 1381
=======================================
Hits 648 648
Misses 1300 1300
Partials 512 512 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6ea164b to
292341f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the GitHub Actions CI workflow to improve security, expand platform coverage, and modernize dependencies. The changes include pinning action versions to commit SHAs, upgrading Python versions, adding security hardening, and extending macOS builds to support both ARM64 and x86_64 architectures.
- Pins all GitHub Actions to specific commit SHAs for improved security
- Upgrades Python from 3.12 to 3.13 on macOS and removes version pin for meson
- Adds matrix build support for both macOS ARM64 and x86_64 architectures
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| export CPPFLAGS="-I$HOME/BUILD_x86_64-apple-darwin/INSTALL/include" | ||
| meson . build | ||
| MESON_CROSSFILE="$HOME/BUILD_${{matrix.arch_name}}/meson_cross_file.txt" | ||
| if [ -e $MESON_CROSSFILE ]; then |
Copilot
AI
Nov 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable $MESON_CROSSFILE should be quoted to handle potential spaces in paths. Without quotes, the test will fail if the path contains spaces. Change to if [ -e "$MESON_CROSSFILE" ]; then.
| if [ -e $MESON_CROSSFILE ]; then | |
| if [ -e "$MESON_CROSSFILE" ]; then |
| meson . build | ||
| MESON_CROSSFILE="$HOME/BUILD_${{matrix.arch_name}}/meson_cross_file.txt" | ||
| if [ -e $MESON_CROSSFILE ]; then | ||
| MESON_OPTION="$MESON_OPTION --cross-file $MESON_CROSSFILE -Dstatic-linkage=true" |
Copilot
AI
Nov 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable $MESON_CROSSFILE should be quoted to prevent word splitting. Without quotes, paths with spaces will cause the command to fail. Change to MESON_OPTION=\"$MESON_OPTION --cross-file $MESON_CROSSFILE -Dstatic-linkage=true\".
| MESON_OPTION="$MESON_OPTION --cross-file $MESON_CROSSFILE -Dstatic-linkage=true" | |
| MESON_OPTION="$MESON_OPTION --cross-file \"$MESON_CROSSFILE\" -Dstatic-linkage=true" |
| MESON_CROSSFILE="$HOME/BUILD_${{matrix.arch_name}}/meson_cross_file.txt" | ||
| if [ -e $MESON_CROSSFILE ]; then | ||
| MESON_OPTION="$MESON_OPTION --cross-file $MESON_CROSSFILE -Dstatic-linkage=true" | ||
| cat $MESON_CROSSFILE |
Copilot
AI
Nov 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable $MESON_CROSSFILE should be quoted to handle potential spaces in paths. Without quotes, the cat command will fail if the path contains spaces. Change to cat \"$MESON_CROSSFILE\".
| cat $MESON_CROSSFILE | |
| cat "$MESON_CROSSFILE" |
011062a to
0c5913f
Compare
0c5913f to
fe5653a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Move to "latest" macOS 15 to match the dependences built by kiwix-build. Adding support of aarch64 testing in the CI