libdatachannel: add new package #27622
Conversation
mourenZhu
force-pushed
the
libdatachannel
branch
from
024fce7 to
1fbbf00
Compare
| define Package/libdatachannel/install | ||
| $(INSTALL_DIR) $(1)/usr/lib | ||
| $(CP) $(PKG_INSTALL_DIR)/usr/lib/libdatachannel.so* $(1)/usr/lib/ | ||
| endef |
There was a problem hiding this comment.
updated so that it will not conflict with ABI versioning
There was a problem hiding this comment.
I still dont see that there is ABI_VERSION.
| define Package/libdatachannel | ||
| SECTION:=libs | ||
| CATEGORY:=Libraries | ||
| TITLE:=libdatachannel | ||
| URL:=https://libdatachannel.org/ | ||
| DEPENDS:=+libstdcpp +libopenssl +libsrtp2 | ||
| endef |
There was a problem hiding this comment.
Here should be indentation as two spaces instead of tab.
Libdatachannel is useful for enabling real-time audio and video transmission on edge devices that run OpenWrt, such as for video conferencing, real-time AI voice applications, and similar scenarios. The size of the library is 2.4 MB. Currently, I don’t have any plans to develop applications based on libdatachannel. |
|
Okay, I understand that the library can serve various purposes, but how exactly do you plan to use it with OpenWrt? Surely there must be some application that will make use of it. Right now, it seems to me that we’re adding the library without actually using it anywhere. |
For example, a program using the libdatachannel library could communicate with OpenAI's Realtime API (which uses WebRTC), allowing an OpenWrt device to receive audio input from a user and interact with AI services. While there isn’t a current application using libdatachannel on OpenWrt, I added this package to prepare for possible future use cases. If you think the library is not needed at the moment, I understand and will close this pull request. |
libdatachannel is an open-source software library implementing WebRTC Data Channels, WebRTC Media Transport, and WebSockets. Details about score can be obtained at https://github.com/paullouisageneau/libdatachannel/blob/master/README.md Signed-off-by: Biao Zhu <[email protected]>
mourenZhu
force-pushed
the
libdatachannel
branch
from
1fbbf00 to
ec2cf46
Compare
|
Just my 2 cents, I don't want to accept a library without users. We have such examples in the past and many of them ended up unmaintained. |
There was a problem hiding this comment.
There are only a few comments you can check if you want, but as three people (including myself, @GeorgeSapkin, and @1715173329) have already raised concerns about the usefulness of this library, I’m afraid I’ll have to close this pull request.
| PKG_LICENSE_FILES:=LICENSE | ||
| PKG_MAINTAINER:=Biao Zhu <[email protected]> | ||
|
|
||
| PKG_BUILD_PARALLEL:=1 |
There was a problem hiding this comment.
This is default as I was told by @1715173329 if you are using cmake. So it can be dropped.
| endchoice | ||
| endef | ||
|
|
||
| SSL_DEPENDS:=+libopenssl |
There was a problem hiding this comment.
I dont think that we need to have custom SSL variable. You might want to look how it is done in other Makefiles in this repo.
| define Package/libdatachannel/install | ||
| $(INSTALL_DIR) $(1)/usr/lib | ||
| $(CP) $(PKG_INSTALL_DIR)/usr/lib/libdatachannel.so* $(1)/usr/lib/ | ||
| endef |
There was a problem hiding this comment.
I still dont see that there is ABI_VERSION.
3 participants
libdatachannel is an open-source software library
implementing WebRTC Data Channels, WebRTC Media Transport, and WebSockets. Details about oom_score can be obtained at https://github.com/paullouisageneau/libdatachannel/blob/master/README.md
📦 Package Details
Maintainer: @
(You can find this by checking the history of the package
Makefile.)Description:
libdatachannel is a standalone implementation of WebRTC Data Channels, WebRTC Media Transport, and WebSockets in C++ with C bindings for multiple platforms, including GNU/Linux, Android, FreeBSD, Apple macOS, iOS, and Microsoft Windows. WebRTC is a W3C and IETF standard enabling real-time peer-to-peer data and media exchange between two devices.
🧪 Run Testing Details
✅ Formalities
If your PR contains a patch:
git am(e.g., subject line, commit description, etc.)
We must try to upstream patches to reduce maintenance burden.