【PaddlePaddle Hackathon 3 No.102】support paddle elementwise_floordiv #13059

taixiurong · 2022-09-15T04:13:20Z

Details:

support paddle elementwise_floordiv

Reference

paddle paddle1.8 doc links :
https://www.paddlepaddle.org.cn/documentation/docs/zh/1.8/api_cn/layers_cn/elementwise_floordiv_cn.html#elementwise-floordiv
paddle paddle2.x doc links :
https://www.paddlepaddle.org.cn/documentation/docs/zh/api/paddle/floor_divide_cn.html#floor-divide

Unit-test passed

openvino-dev-samples

hi @taixiurong thanks for your contribution.

src/core/tests/frontend/paddle/test_models/gen_scripts/generate_elementwise_ops.py

openvino-dev-samples · 2022-09-15T15:54:53Z

Hi, @meiyang-intel @ceciliapeng2011 could you also help to review this PR, thanks

ceciliapeng2011 · 2022-09-16T00:14:31Z

src/core/tests/frontend/paddle/test_models/gen_scripts/generate_elementwise_ops.py

+    with paddle.static.program_guard(paddle.static.Program(), paddle.static.Program()):
+        node_x = paddle.static.data(name = 'x', shape = x.shape, dtype = in_dtype)
+        node_y = paddle.static.data(name = 'y', shape = y.shape, dtype = in_dtype)
+        if paddle_ver == "1.8":


We have no intention to support paddle 1.8. So I would suggest to remove corresponding code and test cases.

Think twice. Let's settle down this version after we know more about "axis" discrepancy.

this is only for test different api in paddle; other elementwise_op only support paddle 1.8; when those elementwise ops support paddle2.x , you can remove corresponding code and test cases .

Can you please use paddle.version to detect paddle version, instead of using the argument paddle_ver?

if use paddle.version, axis != -1 cannot add in tese cases, you want test axis == -1 ?

if use paddle.version, axis != -1 cannot add in tese cases, you want test axis == -1 ?

We have no intention to support paddle 1.8. We don't hope the name of this argument bring any confusion to developers and users.
But in the op mapper, we could keep your implementation to make some legacy paddle models are supported as well.

So can you simply create the test cases without the implication of paddle version?

Probably simply use both fluid and paddle 2.1 api to create cases. That's all.

src/core/tests/frontend/paddle/test_models/gen_scripts/generate_elementwise_ops.py

openvino-dev-samples · 2022-09-16T01:03:48Z

Please fix clang format error.

It could fixed with 2 options -
Method1:

apt install clang-format-9
enable clang with cmake option: -DENABLE_CLANG_FORMAT=ON
make clang_format_fix_all

Method2:
Select the code your wish to format in VScode and left click it, then 'Format Selection'

openvino-dev-samples · 2022-09-23T03:34:30Z

src/core/tests/frontend/paddle/test_models/gen_scripts/generate_elementwise_ops.py

+                        data_x.astype(dtype), data_y.astype(dtype), axis, dtype)
+
+    data_x = np.random.randint(1, 10, [2, 5, 3, 4])
+    data_y = np.random.randint(1, 5, [3, 4])


Hi @taixiurong could add the test case with negative value, seems Paddle's implementation is aligned with Torch.

Hi @taixiurong could add the test case with negative value, seems Paddle's implementation is aligned with Torch.

yes, i review the paddle code , floor_div to call std::trunc(a/b), https://github.com/PaddlePaddle/Paddle/blob/develop/paddle/phi/kernels/funcs/elementwise_functor.h#L573
but the paddle give a response：

PaddlePaddle/Paddle#46379
2. in this test case , i use a = -2, b = 1, is ok. a = -4, b = 3, z = floor_div(a/b), z = -1。 so want to modiy this logic in openvino?

@ceciliapeng2011 @meiyang-intel what's your opinion ?

@OpenVINO-dev-contest hi paddle fix this bug,
doc: https://github.com/PaddlePaddle/Paddle/pull/46419/files
code: https://github.com/PaddlePaddle/Paddle/pull/45051/files
i fix the code in openvino, tese code like:

the tese result:

do want to push new code ?

of course, you can try it

Can you test float to check if OpenVINO and Paddle can have the same result too? I am afraid they won't.

OpenVINO divide op has an attribute "pythondiv", but works with integer only. That's why the integer tests pass.

openvino/src/core/reference/include/ngraph/runtime/reference/divide.hpp

Line 30 in 7bbd428

if (pythondiv) {

openvino/src/core/include/openvino/op/divide.hpp

Line 29 in 7bbd428

bool pythondiv,

@jane-intel Do you have comments about the algorithm discrepancy of openvino divide and paddle floor_divide? Thanks.

https://github.com/PaddlePaddle/Paddle/blob/develop/paddle/phi/kernels/elementwise_kernel.cc#L144
https://www.paddlepaddle.org.cn/documentation/docs/zh/api/paddle/floor_divide_cn.html#floor-divide
paddle support int and int64, not support float.
the paddle finally to call static_cast(a / b).
https://github.com/PaddlePaddle/Paddle/blob/develop/paddle/phi/kernels/funcs/elementwise_functor.h#L573

in openvino if pythondiv is false , to call out[i] = arg0[i] / arg1[i]

openvino/src/core/reference/include/ngraph/runtime/reference/divide.hpp

Line 48 in 7bbd428

out[i] = arg0[i] / arg1[i];

the logic is same.

src/core/tests/frontend/paddle/op_fuzzy.cpp

taixiurong requested review from a team as code owners September 15, 2022 04:13

taixiurong mentioned this pull request Sep 15, 2022

【PaddlePaddle Hackathon 第三期】任务总览 PaddlePaddle/Paddle#43938

Closed

taixiurong force-pushed the dev branch 2 times, most recently from 75d39a3 to db4369c Compare September 15, 2022 06:08

taixiurong changed the title ~~【Hackathon No.102】support paddle elementwise_floordiv~~ 【PaddlePaddle Hackathon 3 No.102】support paddle elementwise_floordiv Sep 15, 2022

openvino-dev-samples reviewed Sep 15, 2022

View reviewed changes

src/core/tests/frontend/paddle/test_models/gen_scripts/generate_elementwise_ops.py Outdated Show resolved Hide resolved

taixiurong force-pushed the dev branch 2 times, most recently from 858f9e9 to e19dc70 Compare September 15, 2022 14:30

ceciliapeng2011 added category: PDPD FE OpenVINO PaddlePaddle FrontEnd PaddlePaddle Hackathon a Intel and Baidu joint Hackathon event labels Sep 16, 2022

ceciliapeng2011 reviewed Sep 16, 2022

View reviewed changes

taixiurong force-pushed the dev branch 2 times, most recently from d527367 to ea5a609 Compare September 16, 2022 02:54

meiyang-intel approved these changes Sep 16, 2022

View reviewed changes

taixiurong force-pushed the dev branch from ea5a609 to d934cd6 Compare September 16, 2022 07:36

taixiurong requested a review from ceciliapeng2011 September 19, 2022 09:58

taixiurong force-pushed the dev branch 2 times, most recently from ce58b89 to 17840ec Compare September 20, 2022 12:33

ceciliapeng2011 approved these changes Sep 21, 2022

View reviewed changes

taixiurong requested a review from openvino-dev-samples September 21, 2022 07:23

openvino-dev-samples reviewed Sep 23, 2022

View reviewed changes

ilyachur approved these changes Sep 23, 2022

View reviewed changes

taixiurong force-pushed the dev branch 2 times, most recently from 681d47e to 6f54f6f Compare September 26, 2022 02:26

ceciliapeng2011 requested changes Sep 26, 2022

View reviewed changes

src/core/tests/frontend/paddle/op_fuzzy.cpp Show resolved Hide resolved

ceciliapeng2011 approved these changes Sep 27, 2022

View reviewed changes

ceciliapeng2011 self-assigned this Sep 30, 2022

ilyachur enabled auto-merge (squash) September 30, 2022 06:21

auto-merge was automatically disabled October 13, 2022 03:03
Head branch was pushed to by a user without write access

support paddle elementwise_floordiv

b814dc6

taixiurong force-pushed the dev branch from 4c3f2eb to b814dc6 Compare October 14, 2022 03:04

Merge branch 'master' into dev

3ef653a

ilyachur enabled auto-merge (squash) October 14, 2022 03:10

ilyachur merged commit 2d8cf90 into openvinotoolkit:master Oct 20, 2022

ilya-lavrenov added the ExternalPR External contributor label Mar 4, 2023

【PaddlePaddle Hackathon 3 No.102】support paddle elementwise_floordiv #13059

【PaddlePaddle Hackathon 3 No.102】support paddle elementwise_floordiv #13059

Uh oh!

Conversation

taixiurong commented Sep 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details:

Reference

Unit-test passed

Uh oh!

openvino-dev-samples left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

openvino-dev-samples commented Sep 15, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

taixiurong Sep 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

openvino-dev-samples commented Sep 16, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

taixiurong Sep 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

taixiurong Sep 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

taixiurong commented Sep 15, 2022 •

edited

Loading

taixiurong Sep 16, 2022 •

edited

Loading

taixiurong Sep 23, 2022 •

edited

Loading

taixiurong Sep 27, 2022 •

edited

Loading