Skip to content

【PaddlePaddle Hackathon 3】Add Paddle where_index operator #12437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Sep 16, 2022
Merged

【PaddlePaddle Hackathon 3】Add Paddle where_index operator #12437

merged 12 commits into from
Sep 16, 2022

Conversation

@Asthestarsfalll
Copy link
Contributor

@Asthestarsfalll Asthestarsfalll commented Aug 5, 2022

@Asthestarsfalll Asthestarsfalll requested a review from a team as a code owner August 5, 2022 11:17
@Asthestarsfalll Asthestarsfalll changed the title add paddle where_index op 【PaddlePaddle Hackathon 3】Add Paddle where_index operator Aug 5, 2022
@Asthestarsfalll Asthestarsfalll mentioned this pull request Aug 5, 2022
Closed
openvino-dev-samples
openvino-dev-samples reviewed Aug 8, 2022
View reviewed changes
Copy link
Contributor

@openvino-dev-samples openvino-dev-samples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Thanks for your contribution

liubo-intel
liubo-intel reviewed Aug 15, 2022
View reviewed changes
Copy link
Contributor

@liubo-intel liubo-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @Asthestarsfalll : thanks for contribution of this Paddle OP conversion. Have added some suggestions for rank 1 and Boolean type test case coverage. Other parts looks good to me.

@liubo-intel liubo-intel added category: PDPD FE OpenVINO PaddlePaddle FrontEnd PaddlePaddle Hackathon a Intel and Baidu joint Hackathon event labels Aug 15, 2022
@liubo-intel
Copy link
Contributor

liubo-intel commented Sep 1, 2022

Hi, @ceciliapeng2011 : do you have any other comments about this PR? if none, could you please help merge it? tks.

ceciliapeng2011
ceciliapeng2011 requested changes Sep 1, 2022
View reviewed changes
src/core/tests/frontend/paddle/test_models/gen_scripts/generate_where_index.py Outdated
from save_model import saveModel
import sys
import paddle
from paddle.fluid.layer_helper import LayerHelper
Copy link
Contributor

@ceciliapeng2011 ceciliapeng2011 Sep 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use paddle 2.1 api instead of fluid which is obsolete after paddle 1.8 to build unit tests?

Copy link
Contributor Author

@Asthestarsfalll Asthestarsfalll Sep 1, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.
But there is a little diference between paddle.nonzero and where_index.
With the parameter as_tuple=True, paddle.nonzero will convert the output to tuple.

@Asthestarsfalll Asthestarsfalll requested a review from a team as a code owner September 1, 2022 07:02
ilyachur
ilyachur reviewed Sep 13, 2022
View reviewed changes
@Asthestarsfalll @ilyachur
remove opset6
dd33293 
Co-authored-by: Ilya Churaev <[email protected]>
@ilyachur ilyachur enabled auto-merge (squash) September 14, 2022 04:07
@ilyachur ilyachur merged commit 5e977fc into openvinotoolkit:master Sep 16, 2022
@ilya-lavrenov ilya-lavrenov added the ExternalPR External contributor label Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ceciliapeng2011 ceciliapeng2011 ceciliapeng2011 approved these changes

@liubo-intel liubo-intel liubo-intel approved these changes

+2 more reviewers

@ilyachur ilyachur ilyachur approved these changes

@openvino-dev-samples openvino-dev-samples openvino-dev-samples left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

category: PDPD FE OpenVINO PaddlePaddle FrontEnd ExternalPR External contributor PaddlePaddle Hackathon a Intel and Baidu joint Hackathon event

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Asthestarsfalll @liubo-intel @ilyachur @ceciliapeng2011 @openvino-dev-samples @ilya-lavrenov