Fix Meta-Llama-3.1-8B-Instruct chat template #846
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
pavel-esir
force-pushed
the
fix_metallama_3_1_chat
branch
2 times, most recently
from
f352aaf to
6774f4a
Compare
pavel-esir
changed the title
pavel-esir
requested review from
Wovchena,
ilya-lavrenov and
alexeytarakanov
Wovchena
requested changes
Sep 11, 2024
Wovchena
approved these changes
Sep 11, 2024
pavel-esir
commented
Sep 11, 2024
alexeytarakanov
approved these changes
Sep 11, 2024
Merged
via the queue into
openvinotoolkit:releases/2024/4
with commit Sep 11, 2024
14ad54e
33 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order for Llama-3.1to work need to replace none's with undefined.
Also replaced ValuesList -> GenericMap for slicing callback to work
https://github.com/jinja2cpp/Jinja2Cpp/blob/b32fbde7d98d13c34784c332c4a24a6f92c76e38/test/user_callable_test.cpp#L234
ticket CVS-149027