Skip to content

Conversation

wgzintel
Copy link
Contributor

When setting OPENVINO_LOG_LEVEL, print the info of scheduler_config.

SchedulerConfig {
max_num_batched_tokens: 18446744073709551615
num_kv_blocks: 0
cache_size: 0
dynamic_split_fuse: 1
use_cache_eviction: 0
max_num_seqs: 256
enable_prefix_caching: 0
use_sparse_attention: 0
}

@github-actions github-actions bot added category: continuous batching Continuous batching category: CPP API Changes in GenAI C++ public headers no-match-files labels Jul 22, 2025
Copy link
Collaborator

@rkazants rkazants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please add test to show that it is printed out in debug mode and not printed, otherwise

Copy link
Collaborator

@rkazants rkazants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please add tests? Thanks

@wgzintel
Copy link
Contributor Author

wgzintel commented Aug 3, 2025

can you please add tests? Thanks

Yes. Will add.

@wgzintel
Copy link
Contributor Author

wgzintel commented Aug 4, 2025

can you please add tests? Thanks

@rkazants Is there any existing test case I can refer to? Thanks

@Wovchena Wovchena requested review from as-suvorov and Copilot August 4, 2025 06:39
Copilot

This comment was marked as outdated.

@github-actions github-actions bot added the category: Python API Python API for GenAI label Aug 25, 2025
@Wovchena Wovchena requested a review from Copilot September 9, 2025 09:05
Copilot

This comment was marked as outdated.

@Wovchena Wovchena requested a review from Copilot September 10, 2025 08:50
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds debug logging capability for scheduler configuration information when the OPENVINO_LOG_LEVEL environment variable is set. It implements to_string() methods for various configuration classes and integrates scheduler config printing into the ContinuousBatchingPipeline constructors.

Key changes:

  • Added to_string() methods to SchedulerConfig, SparseAttentionConfig, CacheEvictionConfig, and KVCrushConfig classes
  • Added utility function print_scheduler_config_info() to conditionally print scheduler configuration
  • Integrated scheduler config printing into all ContinuousBatchingPipeline constructor paths

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/python/py_continuous_batching_pipeline.cpp Exposed new to_string() methods to Python bindings
src/cpp/src/utils.hpp Added declaration for print_scheduler_config_info() function
src/cpp/src/utils.cpp Implemented print_scheduler_config_info() function
src/cpp/src/continuous_batching/pipeline.cpp Added scheduler config printing calls in all constructor paths
src/cpp/include/openvino/genai/sparse_attention.hpp Added to_string() method to SparseAttentionConfig class
src/cpp/include/openvino/genai/scheduler_config.hpp Added to_string() method to SchedulerConfig class
src/cpp/include/openvino/genai/cache_eviction.hpp Added to_string() methods to KVCrushConfig and CacheEvictionConfig classes

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Wovchena Wovchena requested a review from rkazants September 10, 2025 08:52
@Wovchena
Copy link
Collaborator

can you please add tests? Thanks

All tests are now executed with enabled logging: #2621

@wgzintel
Copy link
Contributor Author

can you please add tests? Thanks

All tests are now executed with enabled logging: #2621

Added test case, pls review again.

@Wovchena Wovchena requested a review from Copilot September 11, 2025 07:53
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions github-actions bot added category: LLM samples GenAI LLM samples category: GGUF GGUF file reader labels Sep 11, 2025
@Wovchena Wovchena enabled auto-merge September 26, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: continuous batching Continuous batching category: CPP API Changes in GenAI C++ public headers category: GGUF GGUF file reader category: LLM samples GenAI LLM samples category: Python API Python API for GenAI no-match-files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants