Skip to content

Conversation

Wovchena
Copy link
Collaborator

No description provided.

@Wovchena Wovchena marked this pull request as ready for review July 16, 2025 14:00
@Wovchena Wovchena requested review from as-suvorov and sbalandi July 16, 2025 14:01
diffusers
datasets==3.6.0
datasets==4.0.0; sys_platform == "linux"
datasets==3.6.0; sys_platform != "linux"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbalandi, should I actually fix the version? Since this is a tool, you may want to relax so it's easier to run for people.

There was upper bound initially that's why I touched this file. Maybe the version requirement can be removed completely?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to leave:
datasets<=4.0.0; sys_platform == "linux"
datasets<4.0.0; sys_platform != "linux"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But are you sure, that load_dataset is not fail with RuntimeError: Dataset scripts are no longer supported, but found ... for wwb ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current state sets the latest datasets version for linux and it passed

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So should wwb's datasets version requirement be relaxed or merge as is?

Copy link
Contributor

@sbalandi sbalandi Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Wovchena I'm very sorry for the long answer, please, relax requirements

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relaxed

@sbalandi sbalandi self-requested a review July 17, 2025 11:48
@Copilot Copilot AI review requested due to automatic review settings September 16, 2025 10:53
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the datasets dependency to use newer versions on Linux platforms and adds torchcodec as a Linux-specific dependency for benchmarking and testing.

  • Updates datasets version constraint from exact pin to minimum version in benchmark requirements
  • Introduces platform-specific datasets versioning with newer version (4.0.0) for Linux
  • Adds torchcodec 0.4.0 as a Linux-only dependency for testing

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
tools/who_what_benchmark/requirements.txt Changes datasets from exact version pin to minimum version constraint
tests/python_tests/requirements.txt Adds platform-specific datasets versioning and torchcodec dependency for Linux

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Wovchena Wovchena added this pull request to the merge queue Sep 25, 2025
@Wovchena Wovchena removed this pull request from the merge queue due to a manual request Sep 25, 2025
@Wovchena Wovchena added this pull request to the merge queue Sep 26, 2025
Merged via the queue into openvinotoolkit:master with commit be8ab96 Sep 26, 2025
159 of 166 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants