fix: weapons only elemental damage #3341
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
murilo09
approved these changes
Feb 7, 2025
|
This PR is stale because it has been open 45 days with no activity. |
10 tasks
MadsonPaulo
approved these changes
Apr 12, 2025
dudantas
approved these changes
Apr 23, 2025
|
|
I'm quite sure that, spells damage is going only physical. No elemental damage is being done, no matter if the weapon has some elemental atk or is pure elemental atk. The melee damage goes elemental, as expected, but spells(skills) go fully physical. |
|
This PR is stale because it has been open 45 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the weapons that has only elemental damages, that was supposed to only deal the elemental damage and not physical.
Behaviour
Actual
Equips an amber axe and attack a creature, it will deal ice damage and physical.
Expected
Equips an amber axe and attack a creature, it should deal only ice damage.
Fixes #issuenumber
Type of change
How Has This Been Tested
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist