error in damage wand/rods with the chain system

[jeswilldbm]

Priority

Low

Area

• Datapack
• Source
• Map
• Other

What happened?

If the chain system is activated, the damage propagates in a chain correctly, but I see a problem, the damage of all the wands/rods is basically the same... so having a "snakebite rod" or a "grand sanguine rod" doesn't seem to have any differences.
I have tested with the ms and it works the same, it would be ideal for the chain system to work in such a way that the damage of the wands/rods is the same as what one can configure for each wand individually, so, thus, a "snakebite rod" would chain hit with lower damage than with a "grand sanguine rod".
I attach a sample:

A possible suggestion would be to have a way to activate the chain system for a specific type of weapon or independently, for example, to activate it only for wands/rods, or only for ek, just as it is blocked for bows/crossbows. I'm not an expert in it and I don't know the difficulty in doing something like that.

For this test, use the latest version available

What OS are you seeing the problem on?

Windows

Code of Conduct

• I agree to follow this project's Code of Conduct

[dudantas]

Are the "snakebite rod" and the "grand sanguine rod" doing the same average damage? I thought I added it to consider the min and max damage of each one.
Isn't that your impression? Since you consider the level and magic level as well?

[jeswilldbm]

Currently, it considers the level and the magic level, however, I don't see any differences in having one wand or the other... so the damage in principle should be based on what is configured in items.xml
for example the snakebite rod has a damage:

and the grand sanguine rod:

So I would say that it is based on the independent damage of each wand/rod, so that if someone wants to edit the damage, just change the values ​​that appear on the wand and thus they will have a stronger weapon. With the current configuration, I see the damage very similar and as an example, I edited the grand sanguine rod and raised the damage like this:

I keep hitting the same thing, so it doesn't consider that damage.

[dudantas]

Ok, I'll review the formula, there must be some adjustments to be made

[juanjox20]

hi i have the same bug, any fix?

[github-actions]

This issue is stale because it has been open 120 days with no activity.

[OpenTibiaMX]

Is this system still not working?

[lBaah]

src/items/weapons/weapon.cpp

Change function WeaponWand::getWeaponDamage to:

int32_t WeaponWand::getWeaponDamage(std::shared_ptr player, std::shared_ptr, std::shared_ptr, bool maxDamage /* = false*/) const {
return maxDamage ? -maxChange : -normal_random(minChange, maxChange);
}

[juanjox20]

src/items/weapons/weapon.cpp

Change function WeaponWand::getWeaponDamage to:

int32_t WeaponWand::getWeaponDamage(std::shared_ptr player, std::shared_ptr, std::shared_ptr, bool maxDamage /* = false*/) const {
return maxDamage ? -maxChange : -normal_random(minChange, maxChange);
}
hi sir, a question can i add u in discord? i added that but i has error when i try to compile i fucking forgot to take a screenshoot but i can show u in video or in stream, not free u said me the price, like i said this system just didint work with sanguine weapons and grand sanguines