Per style options

[eight04]

I'd like to discuss

1. What should be put in the per-style options page?
2. How do we implement the per-style options page?

What should be put in the per-style options page?

• Expose iframes (Allow styles to ask the user for permissions #674) (need more discussion)
• Style origin (Per-style CSS origin option #325) (blocked by Use browser.tabs.insertCSS everywhere #248)
• Auto-update (Access to the update URL #197)
• Update URL (Access to the update URL #197)
• Dark/Light mode (Add: toggle dark/night mode styles automatically #736)
• User inclusion/exclusion (Simplify exclusions #724)
• Priority (Feature Request: Deterministic order or user-defined priority for multiple styles #255)
• Auto-add !important to every declaration internally ([FR] Highest priority option #1202)
• Tags - will be also shown/assigned in manager

How do we implement the per-style options page?

I'd like to avoid modifying manage.html to prevent conflicts with #636. I think we can put the per-style options in the usercss options dialog as a new tab (and maybe the default tab). Therefore, we will get a gear icon for each style consistently.

[narcolepticinsomniac]

My bad, I didn't even notice this issue till I just searched "inclusion".

Therefore, we will get a gear icon for each style consistently.

I guess you're talking about in the manager? I don't see it working in the popup, particularly inclusions.

I think we can put the per-style options in the usercss options dialog as a new tab (and maybe the default tab)

Why a new tab though? Using the usercss dialog in the manager seems logical, but dialogs are not so intertwined with the rest of the UI, that conflicts aren't gonna be some major issue. I don't recall exactly, but I have to think Mottie had all the dialogs functioning properly in the redesign. For the most part, it should be as simple as incorporating the icons.

There's no real reason we need to avoid the manager, or wait for anything. I kinda thought you just wanted to take a break from it at the time. We could incorporate per-style options into either of the existing dialogs, and it should be pretty painless to transition them into the manager redesign, if and when it ever happens.

Edit: Rereading this, I'm thinking you meant a new tab inside the dialog. That didn't really register, since most of my styles aren't usercss, so there'd be no need. I think if you're worried about space, tabs inside a dialog is not the ideal solution. Why not keep them separate and use messageBox() instead?

[eight04]

Why not keep them separate and use messageBox() instead?

1. Consistently display the gear icon.
2. Avoid adding a new icon in the manager and the popup.
3. Avoid modifying manage.html.

most of my styles aren't usercss, so there'd be no need

We can hide the tab bar if usercss options are unavailable.

[narcolepticinsomniac]

Avoid modifying manage.html

I don't think that needs to be a major concern. That manager PR probably already needs quite a bit of work. Whatever changes we make should be pretty trivial to integrate.

I'm not against using usercss dialogs though. I didn't realize you wanted to incorporate per-style options in the popup as well. Inclusions will be a little odd, since only applicable styles are listed. Otherwise, it seems like you have have a good idea what you wanna incorporate, and how. It all sounds pretty solid.

[FranklinYu]

Just to make sure: is the “User inclusion/exclusion” item referring to a list of them? If so then I would like to vote for it. My use case is that I excluded Stack Overflow from “Stack Overflow Dark” style, but in future I would like to review this decision.

[narcolepticinsomniac]

PSA

[eight04]

I have tried to extend usercss config dialog but then found it's too hard to work with the UI.

How about adding a Style settings button to the editor and open a dialog when clicked?

[tophf]

I think the invocation place is the trivial part. The important part is that the implementation should be self-contained so we could place it anywhere. I think it can fit in the usercss config as an additional column to the left of the usercss config if the window width is sufficient or at the top otherwise.

[narcolepticinsomniac]

it's too hard to work with the UI

How so? I thought the general idea was give usercss configs to all entries in the popup and manager, and if the styles actually have usercss configs, make them two tabs inside the config dialog.

[eight04]

Some problems about the button bar: should 2 tabs (usercss var and style settings) share the same button bar? I think style settings should save on change by default so we don't need a button for them. Maybe we should also make usercss var save on change so we can get rid of button bar entirely.

[tophf]

Buttons can stay as is, I see no problem with using them for both types.

Regarding tabs, style settings can be always displayed in a column to the left, otherwise people won't find that additional tab. It can be narrow initially, expanded (or activated) on click: