CORE-983: Error handling for login page fields #1643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[CORE-983] When they have errors, email and password fields will have `aria-invalid=true` and `aria-errormessage` attributes set
RoyEJohnson
force-pushed
the
core-983-error-handling-for-login-fields
branch
from
3672d00 to
e061be1
Compare
mwvolo
approved these changes
Aug 14, 2025
|
❌ Tests failed for Ruby 3.1. Check the workflow run for more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CORE-983
CORE-985
When they have errors, email and password fields will have
aria-invalid=trueandaria-errormessageattributes setRolled 985 in here because the changes are closely related and share code.