Skip to content

Conversation

fmount
Copy link
Contributor

@fmount fmount commented Feb 7, 2024

With webhooks we prevent the Glance deploy unless a backend is specified via customServiceConfig.
It doesn't fail if replicas is set to 0, but in general a backend must be specified.
This patch reinforce what already done by removing the enabled_backends information from 00-config.

Depends-On: openstack-k8s-operators/openstack-operator#1130

Copy link
Contributor

@konan-abhi konan-abhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@abays
Copy link
Contributor

abays commented Feb 7, 2024

/test precommit-check

@fmount
Copy link
Contributor Author

fmount commented Feb 7, 2024

/test glance-operator-build-deploy-tempest

@openshift-ci openshift-ci bot removed the lgtm label Feb 8, 2024
@openshift-ci openshift-ci bot added the lgtm label Feb 8, 2024
@fmount
Copy link
Contributor Author

fmount commented Feb 8, 2024

/test glance-operator-build-deploy-kuttl

1 similar comment
@fmount
Copy link
Contributor Author

fmount commented Feb 9, 2024

/test glance-operator-build-deploy-kuttl

@openshift-ci openshift-ci bot removed the lgtm label Feb 12, 2024
Copy link
Contributor

@konan-abhi konan-abhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@openshift-ci openshift-ci bot added the lgtm label Feb 12, 2024
Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Feb 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, fmount, konan-abhi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [abays,fmount,konan-abhi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label Oct 11, 2024
Copy link
Contributor

openshift-ci bot commented Oct 11, 2024

New changes are detected. LGTM label has been removed.

@fmount
Copy link
Contributor Author

fmount commented Oct 11, 2024

/retest

With webhooks we prevent the glance deploy unless a backend is specified
via customServiceConfig. It doesn't fail if replicas is set to 0, but in
general a backend must be specified.

Signed-off-by: Francesco Pantano <[email protected]>
Copy link
Contributor

openshift-ci bot commented Aug 11, 2025

@fmount: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/glance-operator-build-deploy-tempest 12b786a link true /test glance-operator-build-deploy-tempest

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants