-
Notifications
You must be signed in to change notification settings - Fork 35
fix: open_collective accounts
asset failure
#4799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for failed operations
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ravenac95
approved these changes
Aug 18, 2025
@Jabolol you'll need to move this to the new asset directory. Also, I remove the relative imports in the original file, so I'd do that too. |
Addressed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #4800 and fixes the failing runs on dagster for the new
open_collective/accounts
asset. The errors were two:Firstly, runs timed out in problematic segments. The API timed out with a
503
even when the retry config specified little entries. Since the problem is that some segments inherently timeout, the only thing we can do is log these segments and skip them. We log in Dagster's internal tables the segments that failed with useful metadata.Secondly, some fields have integers over
64
bits, which are known to not work with our current DLT setup. We now convert these ones to strings if encountered.Lastly, it modifies the docs to keep the
graphql_factory
documentation on par with the current setup.