Skip to content

fix: update Microsoft/hcsshim to fix build on Windows #1205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 16, 2025
Merged

fix: update Microsoft/hcsshim to fix build on Windows #1205

merged 1 commit into from
Jan 16, 2025

Conversation

avinal
Copy link
Member

@avinal avinal commented Jan 15, 2025

Changes

Signed-off-by: Avinal Kumar [email protected]

@avinal
fix: update Microsoft/hcsshim to fix build on Windows
89f33e7 
- errdefs package location was changed and that caused panic while
  building for windows
- update Microsoft/hcsshim to 0.12.9 that includes the fix for errdefs
- fixes openshift#1204

Signed-off-by: Avinal Kumar <[email protected]>
@openshift-ci openshift-ci bot requested review from divyansh42 and jkhelil January 15, 2025 07:12
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 15, 2025

@avinal: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 89f33e7 link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@adambkaplan
Copy link
Contributor

Filed #1206 to complement this PR - updating the verify check to cross-compile binaries ensures we don't regress in the future.

@adambkaplan adambkaplan mentioned this pull request Jan 16, 2025
Merged
adambkaplan
adambkaplan approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, avinal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 0e4fe06 into openshift:master Jan 16, 2025
6 of 7 checks passed
@adambkaplan adambkaplan mentioned this pull request May 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adambkaplan adambkaplan adambkaplan approved these changes

@divyansh42 divyansh42 Awaiting requested review from divyansh42

@jkhelil jkhelil Awaiting requested review from jkhelil

Assignees

@adambkaplan adambkaplan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

s2i v1.5.0 Fails to Build for Windows
2 participants
@avinal @adambkaplan